From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 79E026EC56; Thu, 18 Mar 2021 10:51:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 79E026EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616053889; bh=iPRXEJ4j9mq9IE3E7dNtY3ay4ZIYk3VpNWXqkUI2uk8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=M8dfxd2PsGQTWhm152/b8j1yI9TtO2SR+Mq3EEF/wzzuPDX3G6rAHQNIcrmrFzSLT 8x02Gy6nlqjOAPZWZ6bImRC9JNTaHvgWe3OPQEpD8zQW/q9v6gMcvT3L5xFF4Ai+ks Gt1m9YEDp/6W+WlomfQpdO+B+6SkO1nwQLrzebGY= Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 075356EC56 for ; Thu, 18 Mar 2021 10:51:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 075356EC56 Received: by mail-lf1-f43.google.com with SMTP id 75so3047415lfa.2 for ; Thu, 18 Mar 2021 00:51:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=t9qYeAnZJDs2xQswDyo5l4U5lMOAFSsTtbFMs1X7GDY=; b=CIE5E0Ykuf8Vjwf+FG6s48rs3UFw/76CIZx4tUayMkfjTtObSVc7srf2ij7DR0HAXn s8Ayex9MRHn5WLOoGgc/88Y4b/o85X9Iw1eGSCOiNFd7Pow8jIslNh5SyGQe3PE2PxYn 99d3H8RHrVOdFHv6JtlC7MzQTMN7aXsJ5nlgYll2h0Yyj8XhopO1UmKpt9IoLZtZwJMM ayYYfYCVo+vaMG823znmgVvQEQuJ9dGs28UZLWsNFJL29J9ZLdoHueRi7/ho5H0uvvml Ly7Pg6f+RWdnaBbUDqXniba/Se4I/3UjeOUHI4gjAkaYapU9UHpjEo2bHm1vPEmLiCQp jL8Q== X-Gm-Message-State: AOAM531SKI9T8rbvCRIMaWurKfviGT9bgGD1QxAH2HaVsmWustCAiplt kTZZlGUXUhWPXTxpR41BTg== X-Google-Smtp-Source: ABdhPJynv3EFzqgSXlrie2s/aFZYhJLemVQLHxcROkchNvG7MpCMi+8hzrsbzgYLiW3VQFh7Ansjrw== X-Received: by 2002:a05:6512:47b:: with SMTP id x27mr4750257lfd.37.1616053888631; Thu, 18 Mar 2021 00:51:28 -0700 (PDT) Received: from sterling.local ([46.188.68.12]) by smtp.gmail.com with ESMTPSA id b30sm124967lfo.294.2021.03.18.00.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 00:51:28 -0700 (PDT) Received: by sterling.local (Postfix, from userid 1000) id 87096E60068; Thu, 18 Mar 2021 10:51:27 +0300 (MSK) Date: Thu, 18 Mar 2021 10:51:27 +0300 To: Cyrill Gorcunov Message-ID: <20210318075127.GA4019@starling> Mail-Followup-To: Konstantin Osipov , Cyrill Gorcunov , tml , Mons Anderson , Vladislav Shpilevoy , Serge Petrenko , Kirill Yukhin References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> <20210318051812.GB224985@starling> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Konstantin Osipov via Tarantool-patches Reply-To: Konstantin Osipov Cc: Mons Anderson , tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" * Cyrill Gorcunov [21/03/18 10:42]: > Good point, thanks! Kostya, lets clarify some moments: > > 1) We introduce "wal_keep_logs" option which defines > a timeout to kick the cleanup fiber. > 2) If node is anonymous replica we simply ignore this > option. > 3) If this option is set then we have a few subcases: > a) The `_cluster` space is not empty thus thus once > all replicas are subscribed _before_ the timeout > expired we trigger the cleanup fiber since it is > safe to process; > b) If replicas are not connected and timeout is > expired we kick the cleanup fiber; I mean this. > Or you mean to always conside "wal_keep_logs" option > and never trigger the cleanup until it get expired? No. -- Konstantin Osipov, Moscow, Russia