From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C17606EC56; Thu, 18 Mar 2021 08:18:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C17606EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616044694; bh=Y4iAmzIdsGqILqz4q07pdMo0TbjvDm6z8Gq9WBuLOhU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=b407mb6nX+WhzWR3Ln/+SCnfnDAdjXaFgvSGMc/B3ww5SftmEIWLVW6fMLohOzLwS KyYz4N4xWHwaZSn1Rtl5gHrElzAoEtjo4hJHkFdPCIw3pZ/ybBNHLoQb+coBZgZNT6 FWzX6w+dYH6bdgoLofm0mVD3gtqgsHbtPKAKWAnw= Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3BED46EC56 for ; Thu, 18 Mar 2021 08:18:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3BED46EC56 Received: by mail-lf1-f50.google.com with SMTP id 75so2532404lfa.2 for ; Wed, 17 Mar 2021 22:18:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=128hvX9AC/VxDWndYjvnIA5P68QuDQf/VbfSzhKd67g=; b=Fb+OiE9dTjoaZXkuCjE5MnQjtLqtzT+7LFalvs49b4bO922wR4JWOSSCA4+5jXU+QM cZx6M9Bz1nTNdgJAR5mCSHWxkH3tbRXBY3B5oIcQt1tWO4w5DiebPedlBMCWUiPqMzBW +q5z8QCbyp025sul3LiK3A7IbYiJP06InMgaoHajTyRRDOG/8Vk8IiMvFD1sx0AxOBvN Ag92Ajs3R+WTuZZGe3wl0oPiPQzdHNNpJr5CIDnvzqgsv4SA97ZoMX8aHTMBLYPx6Mlh FukkKV7XwhQk2wwV/WsREjVlyvbg3ftKWpO3x6/W3CbQyv8Ubo5ceznvP3Td3IRhYXLt vcPA== X-Gm-Message-State: AOAM531H7lw3nibeiMNDQWxt/I3XympSMgAZcIkKs2qd5ZcVPRpyiQJX F7drlNcdoE9TUgzRROaevg== X-Google-Smtp-Source: ABdhPJxf751i3QfAIIX4csYbvkpyzITmbsV7S7A+jQDcjG3XCJkumZSHProBotkRdXKa6Hwj35MF6Q== X-Received: by 2002:a19:7d43:: with SMTP id y64mr4564123lfc.614.1616044693758; Wed, 17 Mar 2021 22:18:13 -0700 (PDT) Received: from sterling.local ([46.188.68.12]) by smtp.gmail.com with ESMTPSA id v23sm89435lfd.259.2021.03.17.22.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Mar 2021 22:18:13 -0700 (PDT) Received: by sterling.local (Postfix, from userid 1000) id A7A42E60068; Thu, 18 Mar 2021 08:18:12 +0300 (MSK) Date: Thu, 18 Mar 2021 08:18:12 +0300 To: Cyrill Gorcunov Message-ID: <20210318051812.GB224985@starling> Mail-Followup-To: Konstantin Osipov , Cyrill Gorcunov , tml , Mons Anderson , Vladislav Shpilevoy , Serge Petrenko References: <20210317185743.964278-1-gorcunov@gmail.com> <20210317212350.GA224985@starling> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [RFC] gc/xlog: delay xlog cleanup until relays are subscribed X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Konstantin Osipov via Tarantool-patches Reply-To: Konstantin Osipov Cc: Mons Anderson , tml , Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" * Cyrill Gorcunov [21/03/18 00:54]: > On Thu, Mar 18, 2021 at 12:23:50AM +0300, Konstantin Osipov wrote: > > * Cyrill Gorcunov via Tarantool-patches [21/03/17 22:01]: > > > > > In case if replica managed to be far behind the master node > > > (so there are a number of xlog files present after the last > > > master's snapshot) then once master node get restarted it > > > may clean up the xlogs needed by the replica to subscribe > > > in a fast way and instead the replica will have to rejoin > > > reading a number of data back. > > > > Should be in 1.10 as well. > > Sure, but first I need to be sure if current rfc is acceptable > in general and I didn't miss something. I suspect we might > need to extend this code and better to not make some design > mistakes which gonna be hard to resolve later. I've a test > case for this simply didn't posted it yet. This is a case where a configuration setting would be suitable. I don't think it's necessary to keep these logs forever by default, 4-6 hours should be a good default for many setups. Some will set the default to, say, 5 minutes, essentially to keep the old behaviour, and some can set it to infinity, to get the current behaviour of the patch. All tarantool setting follow the convention to start from subsystem name, so it got to be wal_{something}, e.g. wal_keep_logs -- Konstantin Osipov, Moscow, Russia