From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DB1476EC56; Wed, 17 Mar 2021 18:17:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DB1476EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615994252; bh=Gg8MjLk1U0d+BdjsQR2bzllRJ78Dkw1pJ0mLjjGEIRo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lB0ihkXYNe2xL6K17PeJ0RoFeQzeW1wojsju7H4eZkP/paNEEdK7TfP0UVlcLQAmj sVefrWyzTJbnuRIQ8zNouNcKLkVl/gOmZy65yYxDWs3Ms2ekCaS0kS0hM+BIll4b6/ Rt11lXVV7p6jqF+7EjaUwg0h2QaQVfyQ0YfXnCzo= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 09F486EC56 for ; Wed, 17 Mar 2021 18:17:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 09F486EC56 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lMXvP-0002U3-0e; Wed, 17 Mar 2021 18:17:31 +0300 Date: Wed, 17 Mar 2021 18:17:23 +0300 To: Sergey Ostanevich Message-ID: <20210317151723.GC29703@tarantool.org> References: <19e526eec5407d656bbb667870a7a2527ab509a7.1615472551.git.skaplun@tarantool.org> <91E86450-7252-44D8-B6DA-001FD393FB1A@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <91E86450-7252-44D8-B6DA-001FD393FB1A@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96485A7A9FC1318933D9BB3A6B6EC39699F63B747D6EB0AF5182A05F538085040A473EDC35C1D3511FDB0500F2C7B02876983CCD9D7AA579C07B689B88D73B1D0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE752E71F0C64B7C834EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379C6642364E0E74208638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496F1B1A149AD9563F2AACBD9633DC71B21BA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7820CF4CC0E318EFB9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3BEC81E4AEBD6D2BF117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C224902CFACCC19C6E7D3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CE1AEB6AF2DA18B6243847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5C432DF3E293CC00144849DD0C7BDCC9617FE19A4E2DA0137D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EB7BD66E9101C1000D439FC90F1C0A0E305751CE7A9C1297A002481D9CD32AF87265EABD15070BE31D7E09C32AA3244C46D8D9FE40E4F7C62307CF954921A5CAA995755A1445935E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwV/GgY7Z4vWtQORR6iKBIQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382260B8C67E018E8CC3386F8151CBAEB8A3A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] test: add PUC-Rio Lua 5.1 test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, Thanks for you review! On 16.03.21, Sergey Ostanevich wrote: > Hi! > > Thanks for the patch! > > > > > On 12 Mar 2021, at 08:36, Sergey Kaplun wrote: > > > > This patch adds PUC-Rio Lua 5.1 test suite as a part of the LuaJIT > > test suite. Source code taken verbatim from > > https://www.lua.org/tests/lua5.1-tests.tar.gz. > > > > and is slightly modified to be consistent with the > > current LuaJIT's LuaC API. > > > > This should be a different commit, isn’t it? Yes, it does. > > > Some tests may fail after this commit. They will be disabled > > or adapted in the next patches. > > The fact patch causes - even temporarily - some fails is no good. The > only exception is initial commit, that brings original test suite. > Can you please make a consistent change that will left the tests disabled > until they adapted and enabled back? I believe such juggling with enabling/disabling is quite unprofitable. We iteratively fix broken tests within the series making CI green as a result. Even if lib[12].c fails to compile -- it is not a problem, since these libraries are test dependencies, not build ones. Sergey can simply mention the fact the build of suite-related tests is broken, so one can find the comment in commit message while e.g. bisecting the bug. Otherwise, the patches are spoiled with unnecessary changes. > > regards, > Sergos > > > > > -- > > 2.28.0 > > > -- Best regards, IM