From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4D30A6EC56; Wed, 17 Mar 2021 10:33:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4D30A6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615966415; bh=/z1X7IK+aiyEuUvRvPA4CgTIzCuncb2Ix+e40VakQiQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LkdfnLhO6DHz29MYGi297eRHybeYt3C6oTrmqWSkdlYDlckQkH1lDk7LC4521XeDJ nswwzQQifdqUze8cqu17hJQCNIHLFb7QhbgjcGOKsyxvplsH2hWR5ajkdYEIFyjwkf kAMSK5zd4RNvPrpwJ93p5hx/3HWP4mBL1mIUr/zc= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A53D86EC56 for ; Wed, 17 Mar 2021 10:33:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A53D86EC56 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lMQgO-0002MQ-Hs; Wed, 17 Mar 2021 10:33:33 +0300 Date: Wed, 17 Mar 2021 10:32:41 +0300 To: Igor Munkin Message-ID: <20210317073241.GA28016@root> References: <20210317004624.GR9042@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210317004624.GR9042@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD96485A7A9FC1318933D9BB3A6B6EC39699F63B747D6EB0AF5182A05F538085040BA901638978C5E47EB043F7D839075C07B00CE898046ABAAD39D2E2C57A703FF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AB5815F4DE05345AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C59BB75D821356298638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496FE96FCA7A80FB6D2815F4640865D8E9D7A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C224902CFACCC19C6E7D3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C0E67A00557831CF643847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5B28DB6F036CA2557A1DB21D3D104252E3172B807C92452D1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A08F09726D78E07B971F8F651C2904D60A6621FAC74E49B6AC70357921797ED297C41679812C422B1D7E09C32AA3244C8E53D663EF96BBFE81057D15C9D68D47B018FE5BB746DCD1FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojwV/GgY7Z4vVcDCEjRy4IHA== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB417C8A461BC0A6E2B283A751B1855941510D9E7CC3F30091DF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 0/5] Adapt lua-Harness test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, Thanks for the review! On 17.03.21, Igor Munkin wrote: > Sergey, > > Thanks for the series! I've looked onto the updated version on your > branch and it is almost cool! I've polished it a bit: commit message, > typos, etc -- you can see the changes on my branch[1] (CI is green[2]). > If you're OK with them, I'll push the changeset to the trunk. LGTM. What's about Sergos'es naming proposal here [1]? > > Speaking about the changes in Tarantool, I almost OK with them except > the test/luajit-test-init.lua. Consider the comments below. Sorry, I don't get how exactly to consider them, so I answer your questions here. If it necessary I'll push them to the branch (yours or mine). > > ================================================================================ > > diff --git a/cmake/luajit.cmake b/cmake/luajit.cmake > index 1c05e085b..3d37164e8 100644 > --- a/cmake/luajit.cmake > +++ b/cmake/luajit.cmake > diff --git a/test/luajit-test-init.lua b/test/luajit-test-init.lua > index bc4af9748..d3f637156 100644 > --- a/test/luajit-test-init.lua > +++ b/test/luajit-test-init.lua > @@ -1,2 +1,16 @@ > -- Disable strict for Tarantool. > require("strict").off() > + > +-- XXX: lua-Harness test suite uses it's own tap.lua module > +-- that conflicts with the Tarantool's one. > +package.loaded.tap = nil > +-- XXX: lua-Harness test suite checks that utf8 module presents > +-- only in Lua5.3 or moonjit. > +utf8 = nil > + > +-- Add `strict.off()` to `progname` command, that runs child tests > > # If only strict.off is required for child processes, please mention why > # others are not. Other changes are required only for parent process, looks obviously as far as they are not added. > > +-- in some LuaJIT test suites to disable strict there too. > +-- Quotes type is important. > +-- XXX: luacheck thinks that `arg` is read-only global variable. > +-- luacheck: no global > +arg[-1] = arg[-1]..' -e "require[[strict]].off()"' > > # Please, mention how Tarantool parses CLI arguments and why arg[-1] > # contains the binary name despite the given flags. Tarantool stores the script name at index 0 in arg variable and interpreter name at index -1, ignoring other CLI arguments between them. > > # Furthermore, you can get the file path via `debug.getinfo(1).source`, > # so you can reassemble LUAJIT_TEST_COMMAND. However, if this is > # unnecessary, then nevermind. Looks unnecessary and not such easy to configure, ignoring for now. > > ================================================================================ > > On 15.03.21, Sergey Kaplun wrote: > > In this patchset lua-Harness test suite is adapted for the LuaJIT fork > > and Tarantool. > > > > Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5844-adapt-lua-harness-test-suite > > Tarantool's branch for tests: > > https://github.com/tarantool/tarantool/tree/skaplun/gh-5844-adapt-lua-harness-test-suite > > Issues: > > * https://github.com/tarantool/tarantool/issues/5844 > > * https://github.com/tarantool/tarantool/issues/5473 > > > > Changes in v2: > > * glanced commit message for the first patch > > * dropped module renaming > > * separate suite introduction and adjustment > > * dropped unnecessary commits with disabled tests > > > > Mergen Imeev (1): > > test: add lua-Harness test suite > > > > Sergey Kaplun (4): > > test: adjust lua-Harness suite for LuaJIT > > test: adjust lua-Harness test suite for Tarantool > > test: disable 241-standalone of lua-Harness suite > > test: disable 411-luajit of lua-Harness suite > > > > > > > > > -- > > 2.28.0 > > [1]: https://github.com/tarantool/luajit/tree/imun/gh-5844-adapt-lua-harness-test-suite > [2]: https://github.com/tarantool/tarantool/tree/imun/gh-5844-adapt-lua-harness-test-suite > > > > > -- > Best regards, > IM [1]: https://lists.tarantool.org/pipermail/tarantool-patches/2021-March/022733.html -- Best regards, Sergey Kaplun