From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 603EE6EC56; Tue, 16 Mar 2021 15:19:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 603EE6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615897147; bh=Ubx/4K+3708PzAfbQjgPW47vdPSkoO3RCakcIrPUdGI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=X7kt1luZja7pezrhYVkVNCQt3SBWcPwPJw4s+tKmqBpQgfOG0bD+4CHK7tOfY5ZyJ yRYtBPY+3+FWhljcvN4/WCcCo+QTJEAkJJC+tK/H9VlJdnC8JaW2TqvQ6TtQxr1Zti RAhUEYdBszR5nMzoHTZbOkJTJcMz7D/hyGdR21Bw= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A7A0C6EC56 for ; Tue, 16 Mar 2021 15:18:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A7A0C6EC56 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lM8eo-0004Zb-Ga; Tue, 16 Mar 2021 15:18:42 +0300 Date: Tue, 16 Mar 2021 15:18:35 +0300 To: Kirill Yukhin Message-ID: <20210316121835.GO9042@tarantool.org> References: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org> <20210316114522.clirq43gszel7odu@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210316114522.clirq43gszel7odu@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B5A6145416490033C23E814B02A2DD10F00894C459B0CD1B963DEA5601CB8B05E0E010F10A80C233028383AC1A7F5350B37692451E7D5BD79 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E2331B2371EFE129EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DEEC83A7CF8598608638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496F3F7A19D4BB72E4652C3E4C9408EAC163A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C390D92131081DE748117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22490E26A56DB46E81E4089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CB3E4D57BB3B05F1143847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A52C9EAC079EBA2EDC5DC6CE4A1A043E45A6BB675114443FDAD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D50AEDB859DBAD9260F48DE1D74B1FC286ADE8A40318CBA2DA47C1B82295713BDA0312F67621D5E1D7E09C32AA3244C2A12F91F375BAD9282B33117DDF52658E3D93501275E802F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0lqF68UH7yGTg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822350B215A2AB7DF5B65CCEB6C30C42B02A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] asan: suppress all LSAN warnings related to LuaJIT X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Kirill, Thanks for your review! On 16.03.21, Kirill Yukhin wrote: > Hello, > > On 12 мар 23:01, Igor Munkin wrote: > > After porting LuaJIT build system to CMake in commit > > 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build > > system'), its build options are not fully maintained in Tarantool. E.g. > > several compile flags, such as -fomit-frame-pointer, are set within > > LuaJIT CMake machinery and there is no way to tweak them outside. As a > > result ASAN + LSAN build in Tarantool CI[1] reports new leaks related to > > LuaJIT runtime, but there is none of them actually (no source code > > changes are made in scope of the applied patchset). Hence it was decided > > to consider all LuaJIT related warnings as false positives for now and > > suppress them until #5878 is resolved. > > > > [1]: https://github.com/tarantool/tarantool/runs/1999839396 > > > > Follows up #4862 > > Relates to #5878 > > LGTM. Added your tag: | Reviewed-by: Kirill Yukhin > > -- > Regards, Kirill Yukhin -- Best regards, IM