From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D73B36EC56; Tue, 16 Mar 2021 15:18:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D73B36EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615897118; bh=HNADca6hXEg+UPrN+CG6N1bqyFROggKiuxAmpS+MCBA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=vMQzxEEmoqW/errwplNgrmWlo8NmcUH7HDlBX4/guNIhr7mnOzk9yb85doJ/qawgM LuTfk2QjZY1RUN0sJlXmAElkH06tALkAciczai58CafT6Z8Ol95yVeM9CQiq6WDj23 zQVbG/CbLxZb1VEUPzzjKgZ4XE+N88waoOcxNNUI= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 014A76EC56 for ; Tue, 16 Mar 2021 15:18:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 014A76EC56 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lM8eg-0007Aq-Me; Tue, 16 Mar 2021 15:18:35 +0300 Date: Tue, 16 Mar 2021 15:18:27 +0300 To: Kirill Yukhin Message-ID: <20210316121827.GN9042@tarantool.org> References: <537149b963da8dec28624b92a684e3e21a5bb4e1.1615565228.git.imun@tarantool.org> <20210316114608.s6tfnnm6kxyfgrgv@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210316114608.s6tfnnm6kxyfgrgv@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69BD7A9E0863F1CB58A8422FE5281FCC8C800894C459B0CD1B91148926F72A6852B2F115675E633CF7E28383AC1A7F5350BD36804FDD2407D15 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE742D9BD90C58D50E0EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76641A6D7C79D2A7643DE5AAF68033B20272CF422D885C911021389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D6FBC3EC642A93BBCC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCE355FB2A6EFF69C575ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E7351CE60B8040019C36C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-B7AD71C0: 2623F767319EFA42AC98609FCEE262F9192335DD689A58EBAE0174B7F1092AFB772CA28438279D925E43707539E8C35E X-C1DE0DAB: 0D63561A33F958A5FBD40CD427E175F4E5B32F99155E97B317EBD52C699EFD25D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3473457D764E1CDE773ECC4F6FD7ABBE6C3A571DAD34CE0F0B095DF60ED8A30AC48A7321E5D885F11E1D7E09C32AA3244C71375D587939CE400A58D3227B401872A995755A1445935E927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0me6mZFGmOnUQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822D574C485184888EA55A1258471606CC9A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] build: bump CMake minimum version for static build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Kirill, Thanks for your review! On 16.03.21, Kirill Yukhin wrote: > Hello, > > On 12 мар 19:10, Igor Munkin wrote: > > This patch follows up 54e149186348cd3f6e2e403cb48b15ae6c50f7aa > > ('build: update CMake minimum version to 3.1'). As a result of its > > cherry-pick CMake minimum version has not been updated within Docker > > machinery for the old static build pipeline. > > > > The problem was disclosed by moving LuaJIT build system to CMake in > > scope of 5d25b860adbad11fa23d20381c9ad749c16ad856 ('build: adjust LuaJIT > > build system') > > > > Follows up #4862 > > > > Signed-off-by: Igor Munkin > > LGTM. Added your tag: | Reviewed-by: Kirill Yukhin > > -- > Regards, Kirill Yukhin -- Best regards, IM