From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] build: bump CMake minimum version for static build
Date: Tue, 16 Mar 2021 15:18:27 +0300 [thread overview]
Message-ID: <20210316121827.GN9042@tarantool.org> (raw)
In-Reply-To: <20210316114608.s6tfnnm6kxyfgrgv@tarantool.org>
Kirill,
Thanks for your review!
On 16.03.21, Kirill Yukhin wrote:
> Hello,
>
> On 12 мар 19:10, Igor Munkin wrote:
> > This patch follows up 54e149186348cd3f6e2e403cb48b15ae6c50f7aa
> > ('build: update CMake minimum version to 3.1'). As a result of its
> > cherry-pick CMake minimum version has not been updated within Docker
> > machinery for the old static build pipeline.
> >
> > The problem was disclosed by moving LuaJIT build system to CMake in
> > scope of 5d25b860adbad11fa23d20381c9ad749c16ad856 ('build: adjust LuaJIT
> > build system')
> >
> > Follows up #4862
> >
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
>
> LGTM.
Added your tag:
| Reviewed-by: Kirill Yukhin <kyukhin@tarantool.org>
>
> --
> Regards, Kirill Yukhin
--
Best regards,
IM
next prev parent reply other threads:[~2021-03-16 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 16:10 Igor Munkin via Tarantool-patches
2021-03-12 16:15 ` Alexander V. Tikhonov via Tarantool-patches
2021-03-15 15:32 ` Igor Munkin via Tarantool-patches
2021-03-16 11:46 ` Kirill Yukhin via Tarantool-patches
2021-03-16 12:18 ` Igor Munkin via Tarantool-patches [this message]
2021-03-16 12:21 ` Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316121827.GN9042@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=kyukhin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] build: bump CMake minimum version for static build' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox