From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2C21D6EC56; Tue, 16 Mar 2021 14:21:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2C21D6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615893680; bh=N/GOjpUqrUvMMvlKWBw4UsqPR8r4SDMt9TZT1VPyEe8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hSsOd0EO5IYlj4SwETc+L8PECM/DLdHqsJ4ywtn3KlFipLpGvJ2pq2Tbwz+PmjAyG S2B60QUg/ZB74ng7OoLXXBwZgr8ePQl6DbGT3tKCt7O1ayxYHgrdG1owzynJy9kFTh edqbK4ZwipuWENeq0GbsILb4J0MekZTV4g+Bl5Gg= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 94B066EC56 for ; Tue, 16 Mar 2021 14:21:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 94B066EC56 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lM7lG-00073a-MH; Tue, 16 Mar 2021 14:21:19 +0300 Date: Tue, 16 Mar 2021 14:21:11 +0300 To: Sergey Ostanevich Message-ID: <20210316112111.GM9042@tarantool.org> References: <68453AE4-8935-4717-A62C-957CDC0C8E13@tarantool.org> <20210304195821.GA745@root> <7D85A22A-0996-44F3-8748-06E409F27E6D@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7D85A22A-0996-44F3-8748-06E409F27E6D@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B54C6354AEEB3BDF9AAE3283F1E6CEA6100894C459B0CD1B951DC8927DC747C2FB9DCC9CBDCEF9531CE798024B0C04D65DFD01B7CA0B1DCD2 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70A10A23A3B64B805EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063750E64749F09C4ED58638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CF89CA98302ED496FE7E20682D9BC7AB1097EF791575E64DBA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34964A708C60C975A117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22490E26A56DB46E81E4089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CAD67A113071E75DA43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5B6B9DE4EF2E6093D183719021D4B2304C84E84389C6970D9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454E98140CCACB5B356EBB7668D98E6A019C24C854B7FEAD6404390BCBC0650FA868F33D0D87820CF1D7E09C32AA3244CE49CFADC8E13A7C6AF4B0AA208E957233A92A9747B6CC886927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0nppHT87zEZMg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382264DB383FB07B9113606B89B255D5D1BCA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [WIP luajit 00/15] Adapt LuaVela test suites X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergos, Looks like I'm too late here, but I still want to share some thoughts. On 05.03.21, Sergey Ostanevich wrote: > Hi! > > > > On 4 Mar 2021, at 22:58, Sergey Kaplun wrote: > > > > On 04.03.21, Sergey Ostanevich wrote: > >> Hi! > >> > >> Thanks for the patchset - brief review > >> > >> part 1 - obvious, LGTM. > >> > >> part 2 - LGTM, good to have all follow-ups set. > > > > Do you mean to reference all follow-ups inside commit message? > > > > There could be just one - if no specific GH created. Well... In this case the tickets should be mentioned near the changes at least, but I still think all of them should be referenced in the commit message. IMHO, it makes the maintenance and software archeology easier. > > >> > >> part 3 - should have a follow-up ticket to cover all suppressions, if we plan to fix them. > > > > Ditto. > > There are some follow ups that can be grepped by qa and luajit labels. > > > > And this is something I don’t want to do - to grep using lables. The patch should > have reference, so I can see all links at once. Totally agree with you here. > > >> > >> part 4-8 are LGTM > >> > >> part 9 (_G and some modules in Tarantool are different): Are we plan to fix it in some way? There should be a follow-up then. > > > > For now I can't see any good solution, except ignoring them by special > > option like slow tests. > > > > I don’t object to ignore them. My question if we plan to tweak the tests to align > with Tarantool? What will happen to the test if Tarantool will change preloaded > modules? It can be tweaked via LUAJIT_TEST_INIT CMake option. I hope most of the issues will be resolved by it. > > >> > >> parts 10-15 are LGTM > >> > >> Regards, > >> Sergos > > -- Best regards, IM