From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 03BBB6EC56; Tue, 16 Mar 2021 00:06:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03BBB6EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615842392; bh=s9lHg6kgyT9ehyp+AQXBsbycNaLMYGCq5ITMSg71ziw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=PuKGFCjGvfTiuPYSSPwwTXrYM6FNyuAeABP0CT8eTJEYAMc27Ob2su06sPbkpTakL ZO8XDeL6nIU3OBHy8tKnuMMlVsW9hG3i14e+RMsTyj6mlXBa2qPmNmgmz4VfhyZQXE pkjzanHZUyHFJjKHdE40I4pKre+9eUYqKMEde6Lo= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 164346EC56 for ; Tue, 16 Mar 2021 00:06:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 164346EC56 Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lLuPy-00050u-SE; Tue, 16 Mar 2021 00:06:27 +0300 Date: Tue, 16 Mar 2021 00:06:19 +0300 To: Sergey Kaplun Message-ID: <20210315210619.GI9042@tarantool.org> References: <20210315173730.GE9042@tarantool.org> <20210315181028.GB16737@root> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210315181028.GB16737@root> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69BC7A690B93B93DD09EFED8A8D520004C100894C459B0CD1B93C3C4DA9ACC2C2A13CDDEE9CFC095AA351DEC49E61B5071403D3BFA7FB8E1556 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CE015DA2C687B387EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379D15B32FCF98DF428638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7FF294EE7CC9FD50572D754CD57D2D1B746A5EF2BD5A93B3A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22495B4C35AC65A386B3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CB04B26703878C8DC43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20BC34632CCC2A66CABF1C8F96496D4F559 X-C1DE0DAB: 0D63561A33F958A549BE0CFFC7F136C580D4C396113F7819EC4AF932FE1F19FFD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34505665BFD4C70705A9A773A9D79496DBC77E77EC277123A1B4641CC1ED817E3C24C8D1C6EE1A25581D7E09C32AA3244C83F13270F85E1C55334AA5706CC775FEF522A1CF68F4BE05927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0mZVvli/LPOdA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382224CB98C54A512BC706206CD15DDB2281A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 1/5] test: add lua-Harness test suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 15.03.21, Sergey Kaplun wrote: > Igor, > > Thanks for the review! > > On 15.03.21, Igor Munkin wrote: > > Sergey, > > > > Thanks for the patch! > > > > On 15.03.21, Sergey Kaplun wrote: > > > diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt > > > index 99471db..3a42f41 100644 > > > --- a/test/CMakeLists.txt > > > +++ b/test/CMakeLists.txt > > > @@ -43,10 +43,12 @@ endif() > > > set(LUAJIT_TEST_COMMAND "${LUAJIT_TEST_BINARY} -e dofile[[${LUAJIT_TEST_INIT}]]") > > > separate_arguments(LUAJIT_TEST_COMMAND) > > > > > > -add_subdirectory(tarantool-tests) > > > +add_subdirectory(lua-Harness-tests) > > > add_subdirectory(LuaJIT-tests) > > > +add_subdirectory(tarantool-tests) > > > > Why did you choose this order? > > Alphabetically, like in `ls` output. Feel free to propose your own. To conform the alphabetical sort order LuaJIT-tests directory should go before lua-Harness-tests directory. > > > > diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt > > > new file mode 100644 > > > index 0000000..9b35e5a > > > --- /dev/null > > > +++ b/test/lua-Harness-tests/CMakeLists.txt > > > @@ -0,0 +1,49 @@ > > > +# Test suite that has been added from lua-Harness test suite > > > +# in scope of https://github.com/tarantool/tarantool/issues/4473. > > > + > > > +# See the rationale in the root CMakeLists.txt > > > +cmake_minimum_required(VERSION 3.1 FATAL_ERROR) > > > + > > > +find_program(PROVE prove) > > > +if(NOT PROVE) > > > + message(WARNING "`prove' is not found, so lua-Harness-tests target is not generated") > > > + return() > > > +endif() > > > + > > > +set(LUA_TEST_FLAGS --failures --shuffle) > > > > Why did you drop TEST_DEPS variable containing the dependencies? > > Sorry, don't get it. What do you mean? If you look onto my iterative patch in the first review iteration, you'll find TEST_DEPS variable similar to the one in tarantool-tests CMakeLists.txt. I forgot to add it into CMakeLists.txt for LuaJIT-tests and remembered about it in this patch. > > > > > > +if(CMAKE_VERBOSE_MAKEFILE) > > > + list(APPEND LUA_TEST_FLAGS --verbose) > > > +endif() > > > + > > > +string(CONCAT LUA_PATH > > > + "./?.lua\;" > > > + "${CMAKE_CURRENT_SOURCE_DIR}/?.lua\;" > > > + "${LUAJIT_SOURCE_DIR}/?.lua\;" > > > +) > > > > There is not a word regarding such complex LUA_PATH configuration. > > Ok, it can be the one long string, but, in my opinion, this format is > more readable, plus, as a bonus, with it line length is less than 120 > characters. I'll join these lines into one if you insist. This is not the issue (and might be much better that my approach in tarantool-tests and I will patch the test runners to make it conform to one style later). I'm talking about the purpose for each entry. E.g. why do you need both "./?.lua" and "${CMAKE_CURRENT_SOURCE_DIR}/?.lua"? If you need "${LUAJIT_SOURCE_DIR}/?.lua" for jit.* modules, then why it's not required for other suites? Mention this explicitly, please. > > > > > > + > > > +string(CONCAT LUA_CPATH > > > + "./?${CMAKE_SHARED_LIBRARY_SUFFIX}\;" > > > + "${LUAJIT_SOURCE_DIR}/?${CMAKE_SHARED_LIBRARY_SUFFIX}\;" > > > +) > > > > Ditto. > > > > > -- > > > 2.28.0 > > > > > > > -- > > Best regards, > > IM > > -- > Best regards, > Sergey Kaplun -- Best regards, IM