From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B58C06EC56; Mon, 15 Mar 2021 20:48:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B58C06EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615830516; bh=XOUOIwSm2sHSvQVu+S7qgxxko57DLELMQN80/yyncWI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vOujYeVF5rmYettSdKu2ZY7886HZEjlQm0krX9K68GKNHp+z92mGLSNxPFksz0Olk Iz51KUZF6L2yQDA7dRLX1DDavhWQ7LkLrxl52XOr8Mq7XAEYID+y/IPM9jouXHTqp/ UVvKyA1ZOZlP79CRPTfP++47ojHd3ccjsokxdErs= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C83096EC56 for ; Mon, 15 Mar 2021 20:48:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C83096EC56 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1lLrKV-0004n6-7V; Mon, 15 Mar 2021 20:48:35 +0300 Date: Mon, 15 Mar 2021 20:48:49 +0300 To: Roman Khabibov Cc: tarantool-patches@dev.tarantool.org, Roman Khabibov , Sergey Bronnikov Message-ID: <20210315174849.ndfdv3jvnbrtb72p@tkn_work_nb> References: <20201212035155.80282-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201212035155.80282-1-roman.habibov@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B5A6145416490033C23E814B02A2DD10F00894C459B0CD1B951D91C2AC3E84E46E1C15A2BDC7848E7B1FD6207BC44566F45196DB1478570EB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FACF2191C0719DEE8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7FF294EE7CC9FD505ECCFFEC1BB2339EC20C96DCEA8C76B0A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFF1AD90B12BE2E4E0BA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6B88CD9DA8D4EF94B76E601842F6C81A1F004C90652538430CDED94BCBF13EF3B93EC92FD9297F6718AA50765F7900637BC615C5154A25A8BA7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89F680B5A81FBA2CF5035872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DE2850DD75B2526BE5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A50EC3D1C92DE1591AB3A600141AF3331EAF04A856341E9F7DD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A59E724FC7897F76051FBB2A085806DB326EC990D983AC1C7E5379878BE3667BAD04EBEABD05B171D7E09C32AA3244C52A10AC8CA902CE1C39A1A128BB3FE78F2F5F14F68F1805B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0l14M+eaVhKOQ== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE51D91C2AC3E84E46E1C15A2BDC7848E7B7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] test: fix getaddrinfo test on Ubuntu 16.04 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" > diff --git a/test/app/gh-4138-getaddrinfo-errors.result b/test/app/gh-4138-getaddrinfo-errors.result > index d301e3776..62b0721df 100644 > --- a/test/app/gh-4138-getaddrinfo-errors.result > +++ b/test/app/gh-4138-getaddrinfo-errors.result > @@ -28,7 +28,9 @@ function check_err(err) > -- EAI_AGAIN > err == 'getaddrinfo: Temporary failure in name resolution' or > -- EAI_AGAIN > - err == 'getaddrinfo: Name could not be resolved at this time' then > + err == 'getaddrinfo: Name could not be resolved at this time' or > +-- EAI_NONAME > + err == 'getaddrinfo: No address associated with hostname' then It is EAI_NODATA, not EAI_NONAME: | $ gcc -D_GNU_SOURCE -Wall -Wextra -x c <(echo -e '#include \n#include \n#include \n#include \nint main() { printf("%s\\n", gai_strerror(EAI_NONAME)); return 0; }') && ./a.out; rm a.out | Name or service not known | $ gcc -D_GNU_SOURCE -Wall -Wextra -x c <(echo -e '#include \n#include \n#include \n#include \nint main() { printf("%s\\n", gai_strerror(EAI_NODATA)); return 0; }') && ./a.out; rm a.out | No address associated with hostname Anyway, we meet another miscompare after updating FreeBSD from 12.0 to 12.2 (see [1]), so we finally decided to don't check exact error messages. It appears to be too fragile: it depends on OS and network conditions both. The patch 'test: simplify check of error message from getaddrinfo()' from [2] will handle it. [1]: https://github.com/tarantool/tarantool-qa/issues/94 [2]: https://github.com/tarantool/tarantool/pull/5751 WBR, Alexander Turenko.