From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 344696EC56; Mon, 15 Mar 2021 20:44:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 344696EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615830270; bh=RwYbESvUJ8T4/JBiJVUhJmUozWZGvghZYUi8/uzEfuk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=GsoBTsC5IOjOinsaAMreusRpmXsWqqNy3vXB/wRYwzNMjyup+Z9973YQoGxpLLjzB 3ekRSlSQrWh4eJadoawqohL88ILLJDoRXhQ2k65gp+kpa5Pfc94RddjIeFhucXeSFw gkYYvaYsswXENCQpFQ/JbMbDKcZvDorA86vbBwio= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6A32E6EC56 for ; Mon, 15 Mar 2021 20:44:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6A32E6EC56 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lLrGW-0004EP-ET; Mon, 15 Mar 2021 20:44:28 +0300 Date: Mon, 15 Mar 2021 20:44:21 +0300 To: Sergey Kaplun Message-ID: <20210315174421.GG9042@tarantool.org> References: <31d2b8f880693c4af3d47d7c6693acfd79459052.1615819534.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <31d2b8f880693c4af3d47d7c6693acfd79459052.1615819534.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69BBBF766E27323369B0CCE27335774643500894C459B0CD1B92E07BA3BA13C8AFBC2EBC4E36A8BBA92B1FD6207BC44566F9A19E549D04913BF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70D278D70F8433719EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A005C90FB6EB35FF8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7FF294EE7CC9FD50EB072626070EDE0FC545014A49CE1178A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C37EF884183F8E4D67117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22495B4C35AC65A386B3089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C02E240F9393C941343847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5F81530CB59A482DE539E1C77A95B4C3E13A92326B8344003D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D340A58BF0C7EAC340F1A593535838CB1BBF72A370BC925B16592CDFB31775E0F318A6DF7DA300412E71D7E09C32AA3244C93F7FC641ED77B3F3B44FA3F798D3191F165894D92D62706927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0mChS0X/MZ0lA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638225E6565E00888F6A933683ACAC711C516A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 3/5] test: adjust lua-Harness test suite for Tarantool X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, This is ridiculous: you split two similar renames required by the one issue into *two* separate commits, but leaving the changes *totally unrelated to each other* within a single commit. Please, split this patch into two: one for the test directory tweak and another with mocking environment variable in CMake. On 15.03.21, Sergey Kaplun wrote: > This patch makes it possible to run lua-Harness test suite using > Tarantool. > > 203-lexico.t and 301-basic.t is adjusted to valid working with > out-of-source build in Tarantool CI. This is done not only for Tarantool CI, but also for LuaJIT out of source build. > > Inside Tarantool's GitHub-CI there is no defined variable LOGNAME nor > USERNAME. This leads to test failure inside CI, because a string is > expected. So, now USERNAME is set manually via CMake. You mix up "the symptom" and "the root cause" here again. Problem is not in CI, but in the test. See the comment at the end. > > Part of tarantool/tarantool#5844 > Part of tarantool/tarantool#4473 > --- > test/lua-Harness-tests/203-lexico.t | 14 ++++++++++---- > test/lua-Harness-tests/301-basic.t | 6 +++++- > test/lua-Harness-tests/CMakeLists.txt | 4 ++++ > 3 files changed, 19 insertions(+), 5 deletions(-) > > diff --git a/test/lua-Harness-tests/CMakeLists.txt b/test/lua-Harness-tests/CMakeLists.txt > index 9b35e5a..bac279f 100644 > --- a/test/lua-Harness-tests/CMakeLists.txt > +++ b/test/lua-Harness-tests/CMakeLists.txt > @@ -40,6 +40,10 @@ add_custom_command(TARGET lua-Harness-tests > # for more info. > # So use less preferable way for tests. > # See the root CMakeLists.txt for more info. > + # XXX: 309-os.t checks os.getenv() function by examine of > + # USERNAME or LOGNAME enviroment variable. It is not present > + # inside CI by itself, so it is set here manually. Strictly saying, the issue was found in CI, but it doesn't relate directly to CI: this can be done via `unset USERNAME` in you bash. This is nothing else, but just a bad test. You can ask Francois to adjust the test using a bit more popular variable (such as PWD or HOME). For now I propose to change the comment the way below and adjust the commit message regarding the changes made. s/It is not present inside CI by itself/These might not be set in the environment/. > + USERNAME="fperrad" > ${PROVE} ${CMAKE_CURRENT_SOURCE_DIR} > --exec '${LUAJIT_TEST_COMMAND} -l profile_luajit21' > ${LUA_TEST_FLAGS} > -- > 2.28.0 > -- Best regards, IM