From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 68A816EC56; Mon, 15 Mar 2021 16:41:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 68A816EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615815674; bh=G0GO5EJ+9SRijtOaSCrTmkxdOUEsYiIMBuMmFxDAg8E=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CdnYWiD/5y0LE2m8jY4eCNfO5I20Mtzt4Z6wHEPhpyCFOQJFU1qVOCxJ+PkU8yK4f 5v4BH8hOHocEwZHs/QCqaSZt7XaIIStbhTEMpWZ5TS8KijwD8cZIMHoK4sHbwYquvz nuM7AVvCMkBTvQGuZV32fSr9fVC5GT7Gx4D2/5no= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B0CEF6EC56 for ; Mon, 15 Mar 2021 16:41:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B0CEF6EC56 Received: by smtp45.i.mail.ru with esmtpa (envelope-from ) id 1lLnT5-00066E-Uk; Mon, 15 Mar 2021 16:41:12 +0300 Date: Mon, 15 Mar 2021 16:41:10 +0300 To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210315134110.GA8525@hpalx> References: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24774a7e599a4e60ca265b0feacc8e7b5af62fb2.1615576716.git.imun@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69BC7A690B93B93DD09EFED8A8D520004C100894C459B0CD1B9D3E7C423327CA51C1541E7068D1A366DF75D221CB246DF0B53A0125EEE708EC8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE752E71F0C64B7C834EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372D850D7477D401F58638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7FF294EE7CC9FD50D838015925804C21A0547BCEE022D2CAA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34C82C86BFC697D19117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C2249BF3059D42242344A089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CA5583D5FF21A78E543847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FDCD13837A2BCF0203C9F3DD0FB1AF5EB4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5C7D55AA73FE4555919EDB45AB3AC7992B927FDAC79547704D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AA8975497C7004E8274975B3378A66EB242EDBA44D00B4AEF42745BD486A4E0116839B134BA3DF3B1D7E09C32AA3244C216BE43EEB00DFCC20D644481F94CB0A259227199D06760A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0n6VA3X9RWQ9g== X-Mailru-Sender: 3B9A0136629DC91203FBB98BB0AC256EC8D0AAADA7C72B16F45C59CFD3828A445B350AF1A35189FAC6BE15A09D9B9DC7F25921C611F62F88B76B9718D0A84D677D8D5F77027693F59437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] asan: suppress all LSAN warnings related to LuaJIT X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Alexander V. Tikhonov via Tarantool-patches" Reply-To: "Alexander V. Tikhonov" Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi Igor, thanks for your patch, it helped to return 1.10 testing in green, patch LGTM [1]. [1]: https://github.com/tarantool/tarantool/runs/2096939827#step:5:4388 On Fri, Mar 12, 2021 at 11:01:05PM +0300, Igor Munkin wrote: > After porting LuaJIT build system to CMake in commit > 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build > system'), its build options are not fully maintained in Tarantool. E.g. > several compile flags, such as -fomit-frame-pointer, are set within > LuaJIT CMake machinery and there is no way to tweak them outside. As a > result ASAN + LSAN build in Tarantool CI[1] reports new leaks related to > LuaJIT runtime, but there is none of them actually (no source code > changes are made in scope of the applied patchset). Hence it was decided > to consider all LuaJIT related warnings as false positives for now and > suppress them until #5878 is resolved. > > [1]: https://github.com/tarantool/tarantool/runs/1999839396 > > Follows up #4862 > Relates to #5878 > > Signed-off-by: Igor Munkin > --- > > This is a temporary solution, until #5878 is resolved. BTW, it looks > like a ASAN/LSAN problem since, running it with fast_unwind_on_malloc=0 > doesn't make CI green and otherwise I have no idea why > -fno-omit-frame-pointer is obligatory for sanitizers (I found not a > single word in Google sanitizers docs regarding it). Though there is no > problems on the stable branches other than 1.10, I believe this patch > should be applied to all branches containing > 07c83aab5c066ca75c149112b331b4dbb81b3f38 ('build: adjust LuaJIT build > system') to reduce the chance of unexpected CI breakage either on > working or on stable branch. > > Issues: > * https://github.com/tarantool/tarantool/issues/4862 > * https://github.com/tarantool/tarantool/issues/5878 > Branches: one with the patch and another providing CI is green on 1.10 > * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit > * https://github.com/tarantool/tarantool/tree/imun/suppress-asan-for-luajit-1.10 > > asan/lsan.supp | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/asan/lsan.supp b/asan/lsan.supp > index e3b62e653..198df89c3 100644 > --- a/asan/lsan.supp > +++ b/asan/lsan.supp > @@ -24,9 +24,12 @@ leak:Curl_resolver_init > # source: /usr/lib/x86_64-linux-gnu/gconv/UTF-16.so > leak:gconv_init > > -# test: box*/ > +# XXX: All warnings reported for LuaJIT runtime are considered > +# false positive until sanitizers support is not introduced in > +# LuaJIT. See the issue below for more info. > +# https://github.com/tarantool/tarantool/issues/5878 > # source: third_party/luajit > -leak:lj_BC_FUNCC > +leak:lj_* > > # test: box/access.test.lua > # test: box/access_bin.test.lua > -- > 2.25.0 >