From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1F3796EC56; Mon, 15 Mar 2021 15:45:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1F3796EC56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615812330; bh=ZkZfpnnVJew7LnaLA4PI6uS10i9IPHH95hGFY27yYhI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BCY/oIt8eJl6XUUCubROq/3r3pd2gk94eCCtaW/dw3+iaKc79winH65YgmypoMm92 52wAIRm7TNNvVDVwwIRb1ksgJQK+QsTMpZTqgcgXm9/L1NxHZvLl16Sr7vLaPyb2sJ E8+po4AQ5g5pJ4aTv0T/STMUF2QLJnEBYXkDMsUQ= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CD3836EC56 for ; Mon, 15 Mar 2021 15:45:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CD3836EC56 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lLmb8-0001KA-Ln; Mon, 15 Mar 2021 15:45:27 +0300 Date: Mon, 15 Mar 2021 15:45:19 +0300 To: Sergey Kaplun Message-ID: <20210315124519.GX9042@tarantool.org> References: <22c59512a294f80d5576752247298c51b512fe78.1615470667.git.skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <22c59512a294f80d5576752247298c51b512fe78.1615470667.git.skaplun@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B54C6354AEEB3BDF9AAE3283F1E6CEA6100894C459B0CD1B9320420DDBD9AF1F241362663BE99C0A858F648F8049EA8F7F9E87AB62FDAFEE4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7922D113DFDC6D5A3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063745D431239A8C7DA08638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C7FF294EE7CC9FD503422FF02594CFD77E5E2C1CAD63F0438A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7328B01A8D746D8839FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C22495D673F6B91EFC66D089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CDA0371536F40842743847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5CB96D0A0415CCD656D7BE17D3D8D9242BC49FB149B8CA619D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A63B03BCD35E0C0A894BCA77297E810272F0AE19BB00DF0BDD72C33378A6FFBB8813192A733102FC1D7E09C32AA3244CACED6889E42A53C7E8764A3EA0A4F8134DBEAD0ED6C55A80927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmD8gqPF9k0l8r8iTkwzGbA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822C3C679F49D43C645BCBCA89E6EE2D721A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/6] test: disable 305-utf8 of lua-Harness suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for the patch, but it is excess. The issue does not relates to utf8.* functions per se (the are none of them provided by LuaJIT), but rather the way UTF-8 support is checked in the test: if there is "falsy" value stored in global, then test simply checks that UTF-8 support is not expected considering to the loaded profile. Hence, simply make nil in test/luajit-init-test.lua (you can also "unload" it from package.loaded, but this is not obliged, since utf8 is not required in the test) and leave the test itself unmasked. On 12.03.21, Sergey Kaplun wrote: > This patch disables 305-utf8.t from the lua-Harness test suite, because > the built-in utf8 module in Tarantool does not work as expected in the > test. > > Partially the problem mentioned in tarantool/tarantool#5241. > > Part of tarantool/tarantool#5844 > Part of tarantool/tarantool#4473 > --- > test/lua-Harness-tests/{305-utf8.t => 305-utf8.t.disabled} | 0 > 1 file changed, 0 insertions(+), 0 deletions(-) > rename test/lua-Harness-tests/{305-utf8.t => 305-utf8.t.disabled} (100%) > > diff --git a/test/lua-Harness-tests/305-utf8.t b/test/lua-Harness-tests/305-utf8.t.disabled > similarity index 100% > rename from test/lua-Harness-tests/305-utf8.t > rename to test/lua-Harness-tests/305-utf8.t.disabled > -- > 2.28.0 > -- Best regards, IM