From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 15CDE6EC59; Wed, 10 Mar 2021 19:25:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 15CDE6EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615393547; bh=3MB0RzHT+6M+rzxN/H8NFYJh1k52KS5lCjVPL8MytUI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=nRtVA0f0Sn3i4gG3FHJvOIlDgHshqllZkUElA75Tby9kHk9U52G6DO6ZHDRO+QSOz SUjDHJ6cj6h24LheJqJvN6t7a4WLs3WEJWr5kEzftYdwRn2K10OxniHKZ9B9tXQPva of5QXwOqOKzrteYPoCBq9Mw36IaDJpQtm6GH7Wqg= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7538F6EC59 for ; Wed, 10 Mar 2021 19:25:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7538F6EC59 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lK1eJ-000585-Ei; Wed, 10 Mar 2021 19:25:27 +0300 Date: Wed, 10 Mar 2021 19:25:21 +0300 To: Sergey Kaplun , Alexander Turenko Cc: tarantool-patches@dev.tarantool.org Message-ID: <20210310162521.GU9042@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B9676070C5F64E418DB309FBA590CF44700894C459B0CD1B98B3A0FF00FA6F65AEE5136E1D5CEF9953F63A53D7F9ED32122AF0AD8BA8DF889 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EB05B7739F1E6D56EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F91103FA893F53AB8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C11F5982A89E0728CE756422DD5233002DCDC5A9DE37F5BDEA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C224958CDF7FFE3EBBCC0089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C3B6C7E47A292E8D043847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5D3F8F4C8B0FEF7C147E8721114C70037D1842BA68597138CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34505665BFD4C7070560A18FF5ABA09A8D6832C3341015513C7EC0976D4C3597F91DD590C005AD4CC51D7E09C32AA3244CD1081218F8BF2B7BF2941B48CC9307F539C99C45E8D137E9927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojsR8tyFmO15P0C0Ft7okAfg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638222086E239E4B360813AA62AA4CC18C8E7A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" I've checked the patchset into all long-term branches in tarantool/luajit and bumped a new version in 1.10, 2.6, 2.7 and master. On 06.03.21, Igor Munkin wrote: > Unfortunately, luacheck doesn't handle the working directory or one used > in options if it is not a real path. As a result of this patch both > PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used > within luacheck target custom command. > > The issue has been already fixed in Tarantool repo after applying > af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck > invocation in different cases'), and this patch is necessary, since > is the dependency for Tarantool target. > > Relates to mpeterv/luacheck#208 > > Reported-by: Alexander Turenko > Signed-off-by: Igor Munkin > --- > > Branch: https://github.com/tarantool/luajit/tree/imun/luacheck-realpath > CI is green on this branch (see the tick near the HEAD commit): > https://github.com/tarantool/tarantool/tree/imun/fix-luacheck-invocation > > test/CMakeLists.txt | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > > -- > 2.25.0 > -- Best regards, IM