From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3104D6EC59; Wed, 10 Mar 2021 11:18:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3104D6EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615364287; bh=a/oHkudE1NsZZT+QECv+looUEBTgQsup7HEVFTUE4M8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TX4idXfCdrS3Scv3RVvQoPX3OhLipEoEh9Epfu+jBy+4f+b/I0c8RWw2D8pZ0w4W5 ycmLPpIvSKwBcRyUPy5/MVhTCc8eLjXSfVCxTEFx5hNvGUViAyro6OQJDNiGmm9n82 Cu3w4MLg1FHm4quyWMZzhFa9oXgQd7gO3zSNF6aY= Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ED0AD6EC59 for ; Wed, 10 Mar 2021 11:18:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED0AD6EC59 Received: by mail-lj1-f173.google.com with SMTP id i26so12803807ljn.1 for ; Wed, 10 Mar 2021 00:18:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=sr3rKYS20L/AsdbrRL7tpIx8YExEmwHjSF8qhxBUI+E=; b=MUw8N1vCR3dErtGb8RSLDLpP+CDc8cr5KR5DXAXrdVli+bULHZl8UGhk8MQuvDR5jo 9bobjiSi84wEin2UvdV9TVg8MbTuFBQTUKl7XXLFMUTZDEkq5dPW8S+OaJ2PGSYkGwzX 9b1q/h7JsdHPpLj/wAb5rWB7tfCqitD6qDTGkJOMsmvs9upSGA0JTfIagqcksAbWjy0l 29SBsYl+xtNM1mHzMZQKK4sr3jVGxU9GqUGDXgGG0dfFOtxzsvsBiBIh+8E6pZ6re7vO 2zrqv+l4fjyGtw3YsoNlZVu3uBUt6mgUY8c3+JgzKaY+BwRAYtQS+THPnZwAbWtsu4UM coVg== X-Gm-Message-State: AOAM533HB6faCBc2zMNmOs3RPjDV5yy50OUNKLxNOEN+MivApTwpbrgr pW6x2SNI6LGwP3EnvVecZFItb/40Nw== X-Google-Smtp-Source: ABdhPJwliz9TSslgrgT5nbPsoBpProBKSSlQuV6+0s9CDDTLOjLQshbxtJELXO+RBZCQAE9dAfHnxg== X-Received: by 2002:a2e:9ad0:: with SMTP id p16mr1154002ljj.414.1615364285293; Wed, 10 Mar 2021 00:18:05 -0800 (PST) Received: from sterling.local ([46.188.68.12]) by smtp.gmail.com with ESMTPSA id w10sm2920039lji.46.2021.03.10.00.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 00:18:04 -0800 (PST) Received: by sterling.local (Postfix, from userid 1000) id 4AF9BE6006A; Wed, 10 Mar 2021 11:18:04 +0300 (MSK) Date: Wed, 10 Mar 2021 11:18:04 +0300 To: Vladislav Shpilevoy Message-ID: <20210310081804.GA87351@starling> Mail-Followup-To: Konstantin Osipov , Vladislav Shpilevoy , Serge Petrenko , gorcunov@gmail.com, tarantool-patches@dev.tarantool.org References: <20210224193549.70017-1-sergepetrenko@tarantool.org> <26fde1bf-a972-fe03-fffe-818839718394@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <26fde1bf-a972-fe03-fffe-818839718394@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3] wal: introduce limits on simultaneous writes X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Konstantin Osipov via Tarantool-patches Reply-To: Konstantin Osipov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" * Vladislav Shpilevoy via Tarantool-patches [21/03/09 23:44]: > Hi! Thanks for the patch! > > LGTM. > > > https://github.com/tarantool/tarantool/issues/5536 > > https://github.com/tarantool/tarantool/tree/sp/gh-5536-replica-oom I don't understand why you need two parameters, size and len. What difference does it make how many requests are in the queue? The queue is IO and memory bound, not CPU bound, at least not more cpu bound than any other subsystem. Pushing the problem to the user by forcing them to choose not one, but two configuration values is poor design. How am I supposed to know what is the right value for the option? I guess don't know it either - the patch was not followed by a benchmark which would prove the selected defaults are optimal. Tarantool has an incoming throttling limit which makes the whole system work like a clock: it's the fiber pool size and net msg size. They were carefully selected after days and weeks of testing. -- Konstantin Osipov, Moscow, Russia