From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 091A96EC59; Wed, 10 Mar 2021 03:14:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 091A96EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615335295; bh=ezyKGR6zGJI5ELJ25InjyG+BX/AarqOwCaI1KmMCbPg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JQsHW1nr327P5RF+6Y2PQ61SyYc/FocZsr3JghR75tgFKuNata1/MzoZTtIDzmvKw y/WzpUCoHcTnyXM4vhJKn+kqc9T28PF/Czq9WprqewPLaxkUz7G5WfrBCbDHscNk2K xHc6/+P9vZaQZ9H//B8Uoe/FN3XySBn5ICb3B1bI= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E3E126EC59 for ; Wed, 10 Mar 2021 03:14:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E3E126EC59 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lJmUm-0006p6-03; Wed, 10 Mar 2021 03:14:36 +0300 Date: Wed, 10 Mar 2021 03:14:30 +0300 To: Sergey Kaplun Cc: Alexander Turenko , tarantool-patches@dev.tarantool.org Message-ID: <20210310001430.GQ9042@tarantool.org> References: <20210308192635.GG6842@root> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210308192635.GG6842@root> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B68E0B78C18DFC811DDE0A658CF5A64D900894C459B0CD1B910C3AE57F46559D739DF4D03989E6DABD3CD93EED2E5BC13872416D062D2E1BD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7850A3F981F25E362EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375045C080FAAE96148638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC785F3F9DF1C7CBD8EC0B56CF1F2D841E2F89055BC3FB5DA1389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6E5E764EB5D94DBD4CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCB835E6E385EA5AF075ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735F67BA0E7924E9B8DC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20B94CA5A7962AB0B86F38869E95A0B61E4 X-C1DE0DAB: 0D63561A33F958A5A1C676F8F2BAF75F09D142FB4E0194EC55B26239ED6D656AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E3E1DC0F9BD55309375D9F8465D3C9D700EA8415C44FB9AF36A05D6659ED60A50D4DD1EA3107BB071D7E09C32AA3244C8E4D01EF913434F1D3C11ED4335294346C24832127668422927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojsR8tyFmO15PmLTyXD+f1Vw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638222214632A7D50069F566DD76EFFCA61B6A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 08.03.21, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > > LGTM! Added your tag: | Reviewed-by: Sergey Kaplun > > `${LUACHECK_SOURCE_DIR}` and `${LUACHECK_BINARY_DIR}` look more > consistent for me (according to other variables naming), but it's up to > you. > Feel free to ignore. Fixed, squashed, force-pushed to the branch. > > On 06.03.21, Igor Munkin wrote: > > Unfortunately, luacheck doesn't handle the working directory or one used > > in options if it is not a real path. As a result of this patch both > > PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used > > within luacheck target custom command. > > > > The issue has been already fixed in Tarantool repo after applying > > Nit: "same issue" or "similar issue" > Feel free to ignore. The definite article does its job here. Ignoring. > > > af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck > > invocation in different cases'), and this patch is necessary, since > > is the dependency for Tarantool target. > > > > Relates to mpeterv/luacheck#208 > > > > Reported-by: Alexander Turenko > > Signed-off-by: Igor Munkin > > --- > > > > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM