From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 510006EC59; Mon, 8 Mar 2021 22:27:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 510006EC59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1615231645; bh=URQyPeLFcJwmzVbkkockXbWTjaaOV+28k1bYQHWP1Ts=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VM4VYrj7Wikewq82pCc2njRajYdNxL1TS8Ue3GDpz4+/EO8jdnipnPoaov61x0yPL CqTEBnJKwdDUpu1szp2n7wFb7ueBYEzFLscpJOX/gpwOU17w89OUwS00cdo5sdOwzb +thaxlSwTz8Grf0L17fxSO50Ldq2iUh+CJe2gMtM= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E0B586EC59 for ; Mon, 8 Mar 2021 22:27:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E0B586EC59 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1lJLXI-0005qD-0s; Mon, 08 Mar 2021 22:27:24 +0300 Date: Mon, 8 Mar 2021 22:26:35 +0300 To: Igor Munkin Cc: Alexander Turenko , tarantool-patches@dev.tarantool.org Message-ID: <20210308192635.GG6842@root> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69B6D9CBB8C4C1E2C2453F3F16C3D6F3AC500894C459B0CD1B92C84C817ABE32970D760F3CBBAFDB376F1AE5CBECD381DD94044E5D25B716309 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AEF9C2E372EE2CB3EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637A521848D7B067A388638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C1F4A82545730C761B2514BF864004F4165AF0F7D486C50F4A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E97D2AE7161E217F117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C2249D0C9BB9AE6BD5D69089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7CA60C52B68663E2D543847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20B11E32FFC24AE6A495672802400F428F2 X-C1DE0DAB: 0D63561A33F958A5E5DDAE9EC4F186CB7A5BA2C16E325BEDBD8ABE5719ACF30AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D347324AA9FA07FF01EA0A216B15B7916210AE0F7396FFED58346E8EF7A2BED7AB75DEAE2F294C175D41D7E09C32AA3244CB42489CE4DC9CB224E4F5437969D31A3B018FE5BB746DCD1FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUqxEkzHTt/jYgCt4vsK0iQ== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4AE98D2B8BF7E593268FC230C54D778071271C29BF1EAE727F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix luacheck invocation for non-real paths X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM! `${LUACHECK_SOURCE_DIR}` and `${LUACHECK_BINARY_DIR}` look more consistent for me (according to other variables naming), but it's up to you. Feel free to ignore. On 06.03.21, Igor Munkin wrote: > Unfortunately, luacheck doesn't handle the working directory or one used > in options if it is not a real path. As a result of this patch both > PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR are resolved prior to be used > within luacheck target custom command. > > The issue has been already fixed in Tarantool repo after applying Nit: "same issue" or "similar issue" Feel free to ignore. > af448464d15f60b87f1c9ef41a7816911c889459 ('tools: fix luacheck > invocation in different cases'), and this patch is necessary, since > is the dependency for Tarantool target. > > Relates to mpeterv/luacheck#208 > > Reported-by: Alexander Turenko > Signed-off-by: Igor Munkin > --- > -- Best regards, Sergey Kaplun