From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B6DF870201; Sat, 6 Mar 2021 02:24:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B6DF870201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614986680; bh=ZJQ1nm30nx9XX4YV7+3oOznqPB82/RjgKpAIOyfrKvA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sVpUQjhGWsCIneGND1NNGZhVbdDLQ0d/lFtZ9oxed11XL7p+I84WRmu57I91fErIY XdN3urpZR7TI1089y4JFQV5Kid2Tw3oSsLnTyCUFcuohdKTgWH4JiMzW0HQAoCEJfn 7U/zI7OyoFPMd8ADHz93XLMpb6O18bHsoM/ZNoh4= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F7E570201 for ; Sat, 6 Mar 2021 02:24:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F7E570201 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lIJoE-0004f3-5o; Sat, 06 Mar 2021 02:24:38 +0300 Date: Sat, 6 Mar 2021 02:24:32 +0300 To: Alexander Turenko Message-ID: <20210305232432.GN9042@tarantool.org> References: <524c0ce8acc18111ab4c8b36e383ff192779c780.1613661908.git.alexander.turenko@tarantool.org> <20210226181158.GD9042@tarantool.org> <20210303180257.ktityub26cd27ogh@tkn_work_nb> <20210304222106.GM9042@tarantool.org> <20210305035008.hya3vediwfthybv5@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210305035008.hya3vediwfthybv5@tkn_work_nb> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D3134714A9BDB69BE66984610072BB1D09A72A4B5C8F966400894C459B0CD1B927CB85EC639CAB8ED2CB063787AF2EE16677C0ECB5D63E1D8E47C47A18F2969E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79A02CDD1178524C2EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063771C846A5973DEE7E8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCE6721B3320ED69CAAE63FB31C29D6A6539F8447C720A8826389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6042F1592492B88C6CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCB835E6E385EA5AF075ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20B2BFB33BE6C544648EE9F84B50AADE487 X-C1DE0DAB: 0D63561A33F958A574879B1B3AC6B3C25D6904F670799EABF9301F238FC89E40D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348D68DCC07DD06FF5233A2663FE8299F982477484A1AC5B747AD4057C7174D90378A61B9090FB63C81D7E09C32AA3244CCF63520C0D57E6B7C7ABBF20B8CCDA5EC3B3ADDA61883BB5927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojXmjzTEesUQF2tmzWxGfsjA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F6B3933BACAFF06F751D119C18900215A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2] tools: fix luacheck invocation in different cases X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sasha, On 05.03.21, Alexander Turenko wrote: > > > > BTW, while looking into the problem with Igor, we found that luajit's > > > luacheck rule fails on source / build paths with symlinks components. > > > The solution is to use real paths everywhere. > > > > I take this upon myself. > > Thank you! Here is the patch[1]. > > I should mention that there is the problem with the LuaJIT CMake rule in > the commit message. > > | -Now `make luacheck` gracefully handles different cases: in-source > | +Now `make luacheck` gracefully handles different cases[^1]: in-source > | and out-of-source build (within the source tree or outside), current > | working directory as a real path or with symlink components. > | > | <...> > | > | +[^1]: We have the similar problems with LuaJIT's luacheck rule. They > | + will be fixed in a separate patch. > | > | [1]: https://github.com/mpeterv/luacheck/issues/208 > | > | +Reviewed-by: Sergey Bronnikov > | +Reviewed-by: Igor Munkin > [1]: https://lists.tarantool.org/tarantool-patches/de1139d94e7501628e69e56d7837fc76cf6b5120.1614986102.git.imun@tarantool.org/T/#u -- Best regards, IM