From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47B1A70310; Thu, 4 Mar 2021 16:36:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47B1A70310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614864962; bh=nQNQxnmDrDasxUSlsYyYV9pgbMcOaDJBY0OogOQOAig=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=JczZvwZxGTmFy4z5bbHH8cU12IaQJk5rI2vCoNSot5+X/QMcqG+wfZZgZT9zWFFUg bHJgKN/ILC4mCfiLarJ6DnZkgkHb51QppU8DJI3+lHQ6thDr7h8dvsMiWBdsFtvltM ajyqxcDrnHQxKuws1ps5gV6MAa1nwkDf6sHN3oe4= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E172170310 for ; Thu, 4 Mar 2021 16:36:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E172170310 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1lHo92-0005rM-2w; Thu, 04 Mar 2021 16:36:00 +0300 Date: Thu, 4 Mar 2021 16:35:12 +0300 To: Sergey Ostanevich Message-ID: <20210304133512.GF6842@root> References: <20210216201044.20952-1-skaplun@tarantool.org> <20210226220704.GF9042@tarantool.org> <790A703F-AB21-4C0C-8178-DC85E8336B2A@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <790A703F-AB21-4C0C-8178-DC85E8336B2A@tarantool.org> X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92A98208ECBDD29F51A014079BC0C7C459F7160AC7246F773182A05F538085040C589B96CF295CD6BC5C4D3C057C9D143F8A793DAF682544C34501DA2727E66A8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7023D31FF4FEF767AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BD378188104BC8BE8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CDB1C6D2319E1F1677EEAC942573A534BA90148DBF7B1E147A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C34C82C86BFC697D19117882F4460429728AD0CFFFB425014E868A13BD56FB6657A7F4EDE966BC389F9E8FC8737B5C2249D635BA3ABDB36C18089D37D7C0E48F6CCF19DD082D7633A0E7DDDDC251EA7DABAAAE862A0553A39223F8577A6DFFEA7C3DDF88F19B2F251A43847C11F186F3C5E7DDDDC251EA7DABCC89B49CDF41148FA8EF81845B15A4842623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A593EB2C0C403A07225FEB1CB94C204E30B23113ECA96ACED5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D50AEDB859DBAD930D748D7AB9963E447690F57988BDF0D94F5F7030C713EFEC8C5DB63E41006991D7E09C32AA3244C98BA06D137CF6547B8CB981DBE64D296E8FBBEFAE1C4874CFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSsmoOoMLSh1uEWX46+lmpg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4FCDAB0AC2C2A2E049F96746EDB9011FF8735D1064880384AF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] core: fix cdata decrementing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergos! Thanks for the review! Added your tag: | Reviewed-by: Sergey Ostanevich On 02.03.21, Sergey Ostanevich wrote: > Hi! > > Thanks for the patch! > LGTM on the changes, still I can see a number of places you do not > collect information about GC objects being created, although > they all about function parsing/creating. > > Are we intentionally not looking into these? I've checked these chunks again: | $ grep lj_mem_newgco -R ../src | grep GC | grep -v -e ircall -e FASTCALL | ../src/lj_parse.c: pt = (GCproto *)lj_mem_newgco(L, (MSize)sizept); | ../src/lj_bcread.c: pt = (GCproto *)lj_mem_newgco(ls->L, (MSize)sizept); | ../src/lj_tab.c: t = (GCtab *)lj_mem_newgco(L, sizetabcolo(asize)); | ../src/lj_func.c: GCupval *uv = (GCupval *)lj_mem_newgco(L, sizeof(GCupval)); | ../src/lj_func.c: GCfunc *fn = (GCfunc *)lj_mem_newgco(L, sizeCfunc(nelems)); | ../src/lj_func.c: GCfunc *fn = (GCfunc *)lj_mem_newgco(L, sizeLfunc((MSize)pt->sizeuv)); | ../src/lj_cdata.h: cd = (GCcdata *)lj_mem_newgco(cts->L, sizeof(GCcdata) + sz); | ../src/lj_cdata.h: GCcdata *cd = (GCcdata *)lj_mem_newgco(L, sizeof(GCcdata) + sz); We count tabs and cdata correctly. As for prototypes, upvalues and functions counters -- they are not reported by design for now. > > regards, > Sergos > -- Best regards, Sergey Kaplun