From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 40B8A6EC6F; Fri, 26 Feb 2021 11:13:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 40B8A6EC6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614327214; bh=oM/UyBk7L6bYMhn4obW/ssczvUns8I3R4tpvDW7LXUg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tnXeIMcSqGZzq2H0t6qqZfjTMFmT/sfuivVgWcZfbl9jzNI82cQAgWNFQgMmNocDL P6p/GV3+7X9hkptMsg1y8Rq6xBPGUGrG3rrjUONhNWOeAFr9kBCqdGSeKxxYbSxSyA SiHys9x4NT3YkYBgDKZAGbzRLTJuP4sQ09W1SLs0= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AC8C36EC6F for ; Fri, 26 Feb 2021 11:13:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AC8C36EC6F Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1lFYFf-00058n-Rb; Fri, 26 Feb 2021 11:13:32 +0300 Date: Fri, 26 Feb 2021 08:13:31 +0000 To: Vladislav Shpilevoy Message-ID: <20210226081331.GA26080@tarantool.org> References: <20210222182030.76232-1-gorcunov@gmail.com> <20210224153626.121506-1-gorcunov@gmail.com> <20210224153626.121506-7-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD975C3EC174F56692242B8E6687D03D8974314021AB65B8FCC182A05F538085040B2F68367DCDFD181C5AE48ACA4610AADFC584C57030C1ECB12015921E9AD7FB8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F09446BC3D835A58EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637BA5555A0C16230F4EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C51D2EACE68E2850F36811490794812B3CC21C02DE043657E9FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B3733B5EC72352B9FA471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC0A66153DDAE413183AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F7900637596275C8727C20D2EC76A7562686271EEC990983EF5C032935872C767BF85DA29E625A9149C048EE22A4E020D69BCAC15E97997F8902A7B94AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8B57326309B7B54F2D75ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF5797B92FCB1594A39500306258E7E6ABB4E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E92315FF39D8DB89857825EFA8BF88FCBFD63CE0852D54D1EC518119AC835912DECA1AB724F4E3BD641098 X-C1DE0DAB: 0D63561A33F958A545358A8D68D59DB50F641908B66583A8A32048312F3CC41BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75968C9853642EB7C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C5CF6F4B28551E3F21A8D07FF7499E7CA65FB447AD3A8A8D7B86659C4EC189A78DB5C278D2C4DA7F1D7E09C32AA3244CE2C2341530D7F9A7C70988FF154F2D115A1673A01BA68E40FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj8mqzvzJVEn3yX7zQcI3ong== X-Mailru-Sender: 5E616C0FE969A709BC2841F6A3283ABF54518F4A94A719C7348FF09814BA06906CD94E02192C25FDDDAB76DE2EFCC57FE67C000C8395E179911E6ECAD2435D151D139210CB918485112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 06/10] box/vynil: fix say_x format X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Nikita Pettik via Tarantool-patches Reply-To: Nikita Pettik Cc: tml Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 24 Feb 23:43, Vladislav Shpilevoy wrote: > Thanks for the patch! > > This bug could actually lead to a crash. Because the printer would > try to read memory by a not passed string pointer. > > Nikita, does it look related to any of the crashes we have in vinyl? No, it doesn't. Errors at compatin start are rather rare. > On 24.02.2021 16:36, Cyrill Gorcunov wrote: > > Drop redundant "%s" from format. > > > > Part-of #5846 > > > > Signed-off-by: Cyrill Gorcunov > > --- > > src/box/vy_scheduler.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/box/vy_scheduler.c b/src/box/vy_scheduler.c > > index b641dd9b8..6f6e9c340 100644 > > --- a/src/box/vy_scheduler.c > > +++ b/src/box/vy_scheduler.c > > @@ -1714,7 +1714,7 @@ vy_task_compaction_new(struct vy_scheduler *scheduler, struct vy_worker *worker, > > vy_task_delete(task); > > err_task: > > diag_log(); > > - say_error("%s: could not start compacting range %s: %s", > > + say_error("%s: could not start compacting range %s", > > vy_lsm_name(lsm), vy_range_str(range)); > > return -1; > > } > >