From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2B94E71828; Wed, 24 Feb 2021 18:41:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2B94E71828 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614181294; bh=U40qUnmVaifZqoCibNstpT+Mh+XdRdb1OHZsys1ZcjE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UTOdt6/Z1IB9XyZo3dlwAcFwLknjnqjfh/Wle4ORaecVjlYQLOZ7zi4Q9DzyN5yUP f/pJ2jhCrQJsEGllf6OpwM674rVY759UXsiPCIlz+wkP2+7lrezCb22t1BPubT9cyI DL1CTystOyem//rF7OA/4QnpowQGSkJNmmkJ3gSc= Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 47D0371828 for ; Wed, 24 Feb 2021 18:38:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47D0371828 Received: by mail-lf1-f54.google.com with SMTP id w36so3685609lfu.4 for ; Wed, 24 Feb 2021 07:38:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=q1a3ThDbzSIKwcHUSXLEyy+nkVsvd8D7XotCb3/Lr3M=; b=kX7RNhHufX+fCz2ngEbJHGBLcekpVewiQ7HlHxaQEzBoXzWcKKkP8dSHr1O3dOySFJ w7ThcqYnLHAAqE2o0H8wSbnPPD5drFZ5kQnvF+yNKT6JMUR4MsUp9rrEL2tqJOP5Mwrw vWq2DEb69L7O5YTleSgh3ykdXlceU5wX9EwZhFl1LcgXxtTRcgf9JEO9HVo3toA4gRdj 09NPnpaFNmHC7WHBsrISJXNhJLgGNuK41OKZsxsWK0xdhz/98oF9MwBJLp/226n1pr5e JP6NW1DEfL1oYMrKtDqXb7YWQALnQizWJdrbULMhM+TlESqpW3d1hupcA4v4vFLzSxXA wkgQ== X-Gm-Message-State: AOAM532gFZU8xREVfYA2ADrWjpb7A3A6qZKf04nWeacvwXWFTFHv6vGd XY9EGNqEeUMZQkjSVGYt92IIkDUju9sN4w== X-Google-Smtp-Source: ABdhPJzDuE41I9pr0KSt648yTA5zk2V1TYbNIIy8bfKkUqIiyREPUw7N2HQ28NcacWiMQ6tfeaK71Q== X-Received: by 2002:a05:6512:65:: with SMTP id i5mr12327103lfo.541.1614181108301; Wed, 24 Feb 2021 07:38:28 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id h10sm506298ljb.101.2021.02.24.07.38.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 07:38:27 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id E2A66560282; Wed, 24 Feb 2021 18:36:28 +0300 (MSK) To: tml Date: Wed, 24 Feb 2021 18:36:26 +0300 Message-Id: <20210224153626.121506-11-gorcunov@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210224153626.121506-1-gorcunov@gmail.com> References: <20210222182030.76232-1-gorcunov@gmail.com> <20210224153626.121506-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v2 10/10] say: fix CFORMAT specification X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" The position of first argument to check from is 6, not 0. Looks like our tests with CFORMAT was simply not working since commit 7d12d66e67a1ce843a2712980f4d3ba04bc0d4f2. Lets turn them all back. Part-of #5846 Reported-by: Vladislav Shpilevoy Signed-off-by: Cyrill Gorcunov --- src/lib/core/say.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/core/say.h b/src/lib/core/say.h index fe8251e4c..e1fec8c60 100644 --- a/src/lib/core/say.h +++ b/src/lib/core/say.h @@ -287,7 +287,7 @@ typedef void (*sayfunc_t)(int, const char *, int, const char *, const char *, ...); /** Internal function used to implement say() macros */ -CFORMAT(printf, 5, 0) extern sayfunc_t _say; +CFORMAT(printf, 5, 6) extern sayfunc_t _say; /** * Format and print a message to Tarantool log file. -- 2.29.2