From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EB1F36EC58; Sat, 20 Feb 2021 15:51:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EB1F36EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613825518; bh=Euh0nT4i2cFHq+lKr6OKo84IfRmYM9v+mPCRtWRAUgI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VVNLVUkxNsAyArWNJDIKUht359ZDGMAawucmxdkpXw24T6AJYtgOIBX4q3r3dZDu8 eaac2wfZBqkEBpwYokk3LqignwyoM7atu4ujXz9R51mC4meQGpyjbkLk4qHvEb10Tj /xZBpO877m8TNLrDvQG9HKrlHASjaGJBrd/bwFvY= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 56DBB6EC58 for ; Sat, 20 Feb 2021 15:51:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 56DBB6EC58 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1lDRjo-0004m7-KP; Sat, 20 Feb 2021 15:51:56 +0300 Date: Sat, 20 Feb 2021 15:51:58 +0300 To: Sergey Nikiforov Message-ID: <20210220125158.r6fgljm5cfrqs2ez@tkn_work_nb> References: <20210121153109.5rgx6wttrkkmcrc5@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F56692243410BA6471F0166336C1783AA96243D182A05F5380850405DE601F67401FA494BCEB7FFEB7841B16763A580D6CF647468C62D2A5AF1B4ED X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7011EB7026DD4A9BAEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AB1265E79AFCDEF58638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FCD8E8D49B3732BB3F7FB554333E6070887D3B5A0F50FCC87D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C04CF195F1528592878941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B625DC386152A6764ACC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249AB873984DA10A7C676E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B524A9D4257935C9A3AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE75A9E79F66F1C28F367F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C37C6C241D9975906435872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C934F12F0C005D1A85E5BFE6E7EFDEDCD789D4C264860C145E X-C1DE0DAB: 0D63561A33F958A50A94BB5D415E4A612FBF64EACE68995F793A0B131D154A70D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346BEB6F73FB9D1E4A188CFEB37B48FC5242DB56D57AC1B0278198FE7C015159240BA224C32C2A0AA41D7E09C32AA3244C6665A3D112EA5EF77814F6D5F47AB40151E887DA02A9F7BF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj2CfMKaWP9xsXXukGrzKrSw== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADE611DAAFAB19D68F32889471ABC1DF526B7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 2/2] base64: improve decoder performance X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" So we have four topics: 1. Why don't remove the unused (status storing) code? 2. Internal API changes that we definitely should do: error reporting for too short output buffer. 3. Internal API changes that are subject to discussion: input validation. 4. Optimizations. I highly want to define precisely the internal API first (have agreement on 1, 2, 3 at least, but better have it implemented) and only then discuss optimizations. Otherwise any proposed optimization may become impossible (or just unneeded). Sorry, but I'll postpone the discussion regarding optimizations because of this. WBR, Alexander Turenko.