From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CA89B6EC58; Sat, 20 Feb 2021 14:30:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CA89B6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613820637; bh=fZVU/QoJ39Sb7tehumKnhwZKJ32qOkvmCanCfy3YIqQ=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wgaJTqRzB5HNu2IddNGmiUiZctssWD3mj2Ba76MQraAPRToQCYMxQD3XFWd87JVE2 nWgXHq7UY4GluVRzRBfYfZPBbBbNa0FulLnhl3A1uDQoWsB67mHKsIf/Q+T18w11FY tspEzayOcLCVumzyvsm4NIRk79IvVxtQ7JRnY7d0= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A6B216EC58 for ; Sat, 20 Feb 2021 14:30:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A6B216EC58 Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1lDQT1-0003XI-S2; Sat, 20 Feb 2021 14:30:32 +0300 Date: Sat, 20 Feb 2021 14:30:34 +0300 To: Sergey Nikiforov Message-ID: <20210220113034.zznp7h3nar56o2vn@tkn_work_nb> References: <7f5ce3321cda6d4305282af486ed2f493b920d1f.1610357625.git.void@tarantool.org> <20210121021627.2dzyh7fho2cvjlrz@tkn_work_nb> <0fe951d6-5202-96a0-f3ec-e6b4abd1ee55@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0fe951d6-5202-96a0-f3ec-e6b4abd1ee55@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F56692243410BA6471F0166336C1783AA96243D182A05F538085040871818FB899E7AF601DB946806966E861A98FDE111A9D0F24A4BC62A1BFFCBAF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78AC0750F3304E924EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D70459430292EC88638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC051190C899382BF8D95CF1456296BB000AAF00C3D739017F389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6957A4DEDD2346B42CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22494B699E7079F4100776E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B1EC80F586F04C4973AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE7588D3C263EAE74EA67F23339F89546C5A8DF7F3B2552694A6FED454B719173D6725E5C173C3A84C36174550A02D153F535872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C934F12F0C005D1A85E5BFE6E7EFDEDCD789D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D70AA565972F7DE25355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5E17BD51F4CD9AB40CC3610F4CE9E977C5C408925552BE0A0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53D1911AD7E4199334BEB8FACDA1859F40FC62BB1B8078421A83DA3A6388F29A5042D1B4E4C78E51D7E09C32AA3244C5F05CA5E0500DCAC22A1D1EC2BCD741097FE24653F78E668927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj2CfMKaWP9xt24UA7w4tObg== X-Mailru-Sender: FFAA8E4AEE17E37C3731A083A1A85ADED4A80C9CB7A87B22EE9EA25B7D58955DB7EA9FE7735C3DBFC664A44C781FCEA7C77752E0C033A69EDF9F2CE1E9CF805D8CD356D4F938FF726C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v6 1/2] base64: fix decoder output buffer overrun (reads) X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alexander Turenko via Tarantool-patches Reply-To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Tue, Jan 26, 2021 at 07:48:48PM +0300, Sergey Nikiforov wrote: > On 26.01.2021 19:37, Sergey Nikiforov wrote: > > On 21.01.2021 5:16, Alexander Turenko wrote: > > > On Mon, Jan 11, 2021 at 12:45:00PM +0300, Sergey Nikiforov wrote: > > > > Was caught by base64 test with enabled ASAN. > > > > > > It seems, we have a problem in CI, otherwise it would be detected. At > > > least, I don't see an explicit suppression relevant to the base64 code > > > or disabling the test under this CI job. > > > > > > Can you, please, investigate, how to enable it in CI, so we'll catch the > > > similar problem next time if it'll appear? > > > > ASAN is not used in CI now. Which is clearly wrong. There is something called 'ASAN' in CI, see [1]. And it seems to be problematic. That's why I asked. [1]: https://github.com/tarantool/tarantool/blob/6610bce9bf43a139043518cd76d3c0c81c981ce2/.github/workflows/release_asan_clang11.yml#L36 > > Right now a lot of tests fail if LeakSanitizer is enabled (the default > > for ASAN), but only 1 test (unit/guard.test) fails if LeakSanitizer if > > disabled. So it is quite straightforward: > > > > CC=clang CXX=clang++ cmake . -DENABLE_ASAN=ON && make -j > > ASAN_OPTIONS=detect_leaks=0 test/test-run.py > > > > (test-run.py is launched from several Makefiles) > > > > I propose creating tasks to make unit/guard.test "ASAN-tolerant" (ASAN > > prints warning which causes .result mismatch) and to add ASAN targets to > > CI. Should it be GitLab or GitHub Actions? This is quite specific 'hacky' test and it is okay to exclude it when we're run with ASAN. > > > > We should probably also look on LeakSanitizer issues, some of them are > > probably real bugs and not just tests sloppiness. > > ASAN with LeakSanitizer enabled (the default): > Statistics: > * disabled: 127 > * fail: 755 > * pass: 414 > > Fixing this is a BIG task. We can enable ASAN test by test to a regular CI runs. I've added a note to [2]. [2]: https://github.com/tarantool/tarantool-qa/issues/18