From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 22BF46EC5B; Wed, 17 Feb 2021 15:39:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 22BF46EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613565592; bh=bVdHpUY8VeyvLJDQ+nSmiUuZYBGbmJagUi7/jvXF9xE=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=VMsidPFvGG6jxk4e/0WKG+8UZXUVLQl7041pRCfRM8QWR7Nd0whn/p+Xxk9/U1Elv xpKquJzEDba88AjQlFG1KlAyJvJAX/3y8yQAoRwsSkjwL61OyAfKm2wN3th22MINdg WNm785ZaQQbWZoEwjMk2UJ0/XsV4D0R3KVUa5+Qo= Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5BC486EC5B for ; Wed, 17 Feb 2021 15:39:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5BC486EC5B Received: by mail-lj1-f181.google.com with SMTP id b16so15790250lji.13 for ; Wed, 17 Feb 2021 04:39:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Op7fEmrVOVjz/WGzQyxo8pswCGafkpDFXMwWpvqA6zk=; b=OTSM9QzvmTtxhsPQBATbEVh0qr/ePYh4V8h8ZzKeQLuogo1GQQCu0fkA1RGO8yTaCt 1BkkIXKwZx9lu4JgVBFE0VlBbTIbC6lG6pSRb+vcjg7cnh5R/Ui31LyUKg7fm9gcaV/l 9ru+MjDprJBJkC0zQz2ZyP8HFwnBV5Rq0TUM9557/YqaizPZiAKOVhrSApLUssrDYY6S s+CBDYViGFD3Y0IDnemN+RrUh0peJuG3f5sK9E8zYJ1ZHhAEjBnEb0dzLFaQFdPycC09 QlKTRnTIOpw7XQdHyBeCbzyTIs3HwQfJJD305XoepwiH5YSDME2a351qpR0wqihA0Jkv mkgw== X-Gm-Message-State: AOAM532LaSSrgFyHd10+tX0s2pBxFjftsjaITGF7ughiif8dmDc2zzn8 Yk9cKsbVvz5qeDwjFyDA6TdvRzpSMa4= X-Google-Smtp-Source: ABdhPJzoRjGjJUcqZSjOykqsuF5OLImRU2HBAFrgu8sAasGQ+1PMY93pakPxoCKjOTbsdiTCqW7nYA== X-Received: by 2002:a2e:b605:: with SMTP id r5mr14317188ljn.367.1613565588886; Wed, 17 Feb 2021 04:39:48 -0800 (PST) Received: from grain.localdomain ([5.18.171.94]) by smtp.gmail.com with ESMTPSA id 14sm233961lfr.9.2021.02.17.04.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 04:39:47 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 3DA71560132; Wed, 17 Feb 2021 15:39:47 +0300 (MSK) To: tml Date: Wed, 17 Feb 2021 15:39:43 +0300 Message-Id: <20210217123945.396396-1-gorcunov@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v18 0/2] box: implement cmod Lua module X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Please take a look once time permit. v1-v3 are development ones and not sent. v5 (by vlad): - drop exists, list methods: they are redundant - rename cfunc to cbox - when create a function make it callable Lua object - initialize cbox out of modules - fix error in passing module name for reloading - make api been cbox.func.[create|drop] and cbox.module.reload - fix test for OSX sake v6 (by vlad): - move module handling into module_cache file. v7: - development v8: - use rbtree for function instance storage, since i don't like the idea of unexpected rehashing of values in case of massive number of functions allocated - use reference counter and free function instance if only load/unload are coupled - keep a pointer to the function inside Lua object so we don't need to lookup on every function call. this force us to implement __gc method - use new API and update docs v9: - development v10: - use hashes for function names lookup - simply function loads counting - use luaL_register_module and luaL_register_type for easier methods registering - carry functions as userdata object v11: - development v12: - switch to new API as been discussed in https://lists.tarantool.org/tarantool-patches/e186c454-6765-4776-6433-f3f791ff4c27@tarantool.org/ v13: - development v14: - switch to refs to carry module usage - drop func_name structure renaming - carry two hashes for backward compatibility with functions created via box.schema.func help - complete rework of cmod and most parts of module_cache - account for file statistics to invalidate module cache - new API for cmod, no more :reload, the :load procedure uses cache invalidation - update test cases - still there is no GC test since I didn't manage to deal with it v15: - report module state cached/orphan - update test cases - do not prevent functions lookup in orphan modules - there was an idea to use box.shema.func cache as on top of cmod's one, but this doesn't work because in case if module doesnt exist in any caches we would put it into into cmod's one as well but there wont be a module on cmod level which would clean it up later (which makes code a way more comple if we choose to track state of modules). v16: - internal v17: - drop idea of unifying box.schema.func and cmod functions cache, it brings more problems than solves due to too different context of execution; - make cmod self consistent, which shrink patch series size ~1/5 in compare with previous attempts; - improve tests to account internal states of modules and functions (tt_dev key in reports). v18: - implement pass-through cache for modules loading, for this sake 'struct module' uses cmod internally; - improve tests to cover sole cmod case and a mixture of box.schema.func and cmod to make sure the caches are not corrupted. branch gorcunov/gh-4642-func-ro-18 issue https://github.com/tarantool/tarantool/issues/4642 Cyrill Gorcunov (2): box/cmod: implement cmod Lua module test: box/cfunc -- add cmod test src/box/CMakeLists.txt | 1 + src/box/func.c | 237 ++++------ src/box/func.h | 7 +- src/box/lua/cmod.c | 925 ++++++++++++++++++++++++++++++++++++++++ src/box/lua/cmod.h | 123 ++++++ src/box/lua/init.c | 2 + test/box/CMakeLists.txt | 4 + test/box/cfunc1.c | 58 +++ test/box/cfunc2.c | 137 ++++++ test/box/cfunc3.c | 25 ++ test/box/cfunc4.c | 28 ++ test/box/cmod.result | 527 +++++++++++++++++++++++ test/box/cmod.test.lua | 200 +++++++++ test/box/suite.ini | 2 +- 14 files changed, 2116 insertions(+), 160 deletions(-) create mode 100644 src/box/lua/cmod.c create mode 100644 src/box/lua/cmod.h create mode 100644 test/box/cfunc1.c create mode 100644 test/box/cfunc2.c create mode 100644 test/box/cfunc3.c create mode 100644 test/box/cfunc4.c create mode 100644 test/box/cmod.result create mode 100644 test/box/cmod.test.lua base-commit: 4299daf7df12a67748e28969446c8e8a7530bce1 -- 2.29.2