From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5021170358; Tue, 16 Feb 2021 19:36:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5021170358 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613493414; bh=e/JTfhI4NZq6/ZmWB998rHJEINT0h8VW5pNAPEkqyzo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UZmtPwj1zJ2vanPbpWzRtORZDMdYwH+89oRQ+K7ZmYNd6362Y/z55oMpvq1FowYIc iR9Yp1Kl5HA3fB2ty+vFxLZOICUbCabZLUxRZODPVAEykFHuax/Jo4UNBd6bR+TbwG AsCAdnrLky6WuO8ANgGaj9NYy8Yc+Lq99i5UoB4s= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 141B070358 for ; Tue, 16 Feb 2021 19:36:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 141B070358 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1lC3LF-0007ST-1h; Tue, 16 Feb 2021 19:36:49 +0300 Date: Tue, 16 Feb 2021 19:36:05 +0300 To: Igor Munkin Message-ID: <20210216163605.GK9361@root> References: <2db1d3a53682de0bb4231ec494fc44e95acd9a8f.1612291495.git.imun@tarantool.org> <20210214191626.GF9361@root> <20210216152956.GM5448@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210216152956.GM5448@tarantool.org> X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91883A1EE8D2E9932D86E34B57BE2BEB9CE9F487DD0E8F8BD182A05F5380850401FBCD5604E84063C2486A1058C652B9B8CB4BA0CA8FC3C6DA042BC2CC001ED01 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70312E9A300D47E3BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063750965CC5CDB672DE8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC484813038A5CCF2302F72E28841BEA718801D21D3E9DFAF8389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6042F1592492B88C6CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC08F9A42B2210255C75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E735D028CC0B556B22BCC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F5D41B9178041F3E72623479134186CDE6BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2BBE337FB72E923155C0AF1600DCBC20BF7270DC4A9C1D116C936C597F845EC9E X-C1DE0DAB: 0D63561A33F958A52771FFB6F2EA0BA651DA88171BF4230621ABE2073E47F144D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9A0A0BF1A2CAC6280A4EEA6F74ACAD0E7C11EC1EF584C118C63DB189F198F048E78A781C7CC838A1D7E09C32AA3244C61CBAEF3B4AE306D8BB6C123C365A8AEC86C126E7119A0FEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiBTwj6noE5dxgss26JEj4g== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4D395BB8251C62B72D3B46A6E78F6FA731B5EE00376D5E7FEF2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/5] test: fix warnings found with luacheck in misclib* X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, On 16.02.21, Igor Munkin wrote: > Sergey, > > Thanks for the review! > > On 14.02.21, Sergey Kaplun wrote: > > Hi, Igor! > > > > Thanks for the patch! > > > > Looks like I was late for the ball and you got two LGTMs, but here’s my > > No, you were not! > > > two cents on the matter, because I've been mentioned. Feel free to > > ignore my nitpicks. > > > > LGTM, except two nitpicks below. > > Added your tag: > | Reviewed-by: Sergey Kaplun Thanks! > > > > > On 02.02.21, Igor Munkin wrote: > > > Since the regular static analysis has not been enabled for the test > > > chunks in LuaJIT repository yet, the tests for recently implemented > > > features still produce luacheck warnings. > > > > > > The most of the issues are fixed in scope of the commit > > > 8fc103fb1a21c28185a1942e75d8d9485e3aade7 ('test: fix warnings spotted by > > > luacheck') and this patch fixes the remaining ones. > > > > > > Fixes tarantool/tarantool#5631 > > > > Nit: Looks like 'Closes' or even 'Part of' (considering the next patch), > > not 'Fixes'. > > Why? Sergey pointed out the warnings. The sources and the related > warnings are *fixed*. So 'Fixes' looks the most suitable here. > > > Also, After this patch there are tons of misc-related warnings > > by the luacheсk without config. So, I think that this patch should be > > squashed with the next one. > > Yes, these changes are not atomic. I can simply reorder the patches, if > you insist, but I definitely don't want to squash them into a single > one. The reason is that one is about "enabling" the regular check for > LuaJIT-related sources (#5470), but as a result of the applying > metrics-related series, the introduced chunks have broken luacheck > again. The new warnings are reported in a separate issue (#5631). OK, LGTM. > > > Feel free to ignore. > > > > > Part of tarantool/tarantool#4862 > > > Part of tarantool/tarantool#5470 > > > Follows up tarantool/tarantool#5187 > > > > > > Reported-by: Sergey Bronnikov > > > Signed-off-by: Igor Munkin > > > --- > > > .../misclib-getmetrics-capi.test.lua | 22 ++++++--------- > > > .../misclib-getmetrics-lapi.test.lua | 28 +++++++++---------- > > > 2 files changed, 23 insertions(+), 27 deletions(-) > > > > > > > > > diff --git a/test/tarantool-tests/misclib-getmetrics-lapi.test.lua b/test/tarantool-tests/misclib-getmetrics-lapi.test.lua > > > index 959293d..d54caac 100755 > > > --- a/test/tarantool-tests/misclib-getmetrics-lapi.test.lua > > > +++ b/test/tarantool-tests/misclib-getmetrics-lapi.test.lua > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun