From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E9C9A6EC5A; Mon, 15 Feb 2021 19:30:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9C9A6EC5A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613406606; bh=oUrav3zo1N/6hL3ePYb5JxZZw2q9gbax+Vmd7EM/Idk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I43Wj3ut7pogKqeh+NM6tzdyMEP4tPIR7CWzT1e7L5akAqaPshnKBXP0eegHwjaFQ 0lnLIsMGfR/WR1gGYpbxEVXEk/sRRF/FGC3fm+p50QMxYNmPEICTviYC+zI3qfYeim xgrErSddkwFWvG4a+VMBtl5pBfqRlnKdapFxgx1k= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 49BD46EC5A for ; Mon, 15 Feb 2021 19:30:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 49BD46EC5A Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1lBgl6-0005gq-25; Mon, 15 Feb 2021 19:30:00 +0300 Date: Mon, 15 Feb 2021 19:29:16 +0300 To: Igor Munkin Message-ID: <20210215162916.GJ9361@root> References: <2ac28542e4eac2031e5c30b279aabd3bcacbd7a1.1612390822.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ac28542e4eac2031e5c30b279aabd3bcacbd7a1.1612390822.git.imun@tarantool.org> X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91883A1EE8D2E9932D506EC6BA87A3EB954D62ED708969C42182A05F5380850409D623476E75800218B57038B1B07604A43A11FD13BAD5F24F806980A785D4980 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C6068CE86C2B75F5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637317AD06F2A8D0AEF8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC999110C33E5F4A0F7CC9547FBC62B0251A7BEEB5E0A53A2E389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC08F9A42B2210255C75ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E7356D8C47C27EEC5E9FB5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DBCF17F1EDFBC1FB573B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5620502EFAF1795D1530AACFFE0D7C8809B74DAA417A2A1B9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346AD04FDA812EEFF1896D31993CFFDBA22CF61307D52A9BA5F4AAEFDEA33615CD5A3BBDB52D12EAE91D7E09C32AA3244CD80B25596FF97772ACCC2A06D834DFEF05AB220A9D022EBCFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojiBTwj6noE5dkeFrPuvk5rg== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB484FD7F5AE71399C2D30388A7C26C1BCD0DACDBF337005A97F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/3] ci: enable LuaJIT tests in CI X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a few nits below. On 04.02.21, Igor Munkin wrote: > This patch adds LuaJIT tests to every CI job type except the one for > static build testing routine on OSX: there is no way to run LuaJIT tests > for out of source build on OSX due to SIP[1]. > > [1]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html > > Follows up #4862 Nit: looks like 'Closes' not 'Follows up'. Feel free to ignore. > > Signed-off-by: Igor Munkin > --- > .travis.mk | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) Nit: There is one general comment for the whole patch: In my opinion, it is better to run `make LuaJIT-tests` **before** Tarantool test suite. If LuaJIT is broken failed Tarantool tests information is useless (Is it LuaJIT? Always has been.). Feel free to ignore. > > diff --git a/.travis.mk b/.travis.mk > index 50524007c..c2b79a4e5 100644 > --- a/.travis.mk > +++ b/.travis.mk > @@ -134,6 +134,7 @@ build_debian: configure_debian > + # FIXME: Hell with SIP on OSX: Tarantool (and also LuaJIT) > + # is built out of sources, so the test located in the > + # source directory fails to load the shared library built > + # in the binary directory via dlopen(3). > + # For more info proceed the link below: Typo: s/info, proceed/info proceed/ > + # https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/FileSystemProtections/FileSystemProtections.html > + # Do not run LuaJIT related tests for this built until the > + # issue is not resolved. > + # > + # make -C ${PWD}/static-build/tarantool-prefix/src/tarantool-build LuaJIT-test > -- > 2.25.0 > -- Best regards, Sergey Kaplun