From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 69AE86EC5A; Mon, 15 Feb 2021 16:12:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 69AE86EC5A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613394778; bh=/in1oJ4+//HFDZAzTLjThjNI7i+uS3EUFSzfuvvqVDw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I4RU5qF15HixFc+VBYiWkGHoLdO/xWDS2MtcOw40hqYivTfHe4nHkzF3tz2EDNiXT MBC5AYsS4PdNTnTsz4AzLSipPFye7+/Sa/BySiEFLOeixPsqUmbPRuyw19Qe7fA5wx QB9Ogr+xKA3ArwglLjbKdRdlC0pJQ5hje+vhayaI= Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 06A256EC5A for ; Mon, 15 Feb 2021 16:12:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 06A256EC5A Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1lBdgK-0002yE-R5; Mon, 15 Feb 2021 16:12:53 +0300 Date: Mon, 15 Feb 2021 16:12:09 +0300 To: Igor Munkin Message-ID: <20210215131209.GH9361@root> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD91883A1EE8D2E9932390BCE47895C4D56D93B5151D3975252182A05F538085040782855E6C071DC341CA75DB641C2A038B6132741CCEE8A6F14400DFD0BCB21EA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C674E70A05D1297E1BBC6CDE5D1141D2B1C14384F2D26DDE054849D771480FCE9A23E3DA6831E713FC89FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B2EE5AD8F952D28FBA471835C12D1D977C4224003CC836476EC64975D915A344093EC92FD9297F6718AA50765F7900637B8F435DEDE9E76EBA7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89F616AD31D0D18CD5C35872C767BF85DA2F004C906525384306FED454B719173D6462275124DF8B9C9DF33B08B2BB81206574AF45C6390F7469DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A5C045440C27427CF479E9679EB5508820B9636AAEE7DD04E6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3442AF01057B6BF997893BB88571A2BAECAFC70C6300CB7C294F70AEF8A5DD619AB14B5BB71695C7AC1D7E09C32AA3244C541A8224D670A8DE189104C19193217105AB220A9D022EBCFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojcZK6cmu79qTavRWr8UwUag== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB48494C3C729923504026E14154E9EB39D4364F3BC4F7B3369F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/3] build: fix lua.c file generation X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except one nitpick below. On 04.02.21, Igor Munkin wrote: > If Lua source path given to function is relative, the Typo? s/Lua source path/the Lua source path/ Feel free to ignore. > output file is generated in the binary directory. At the same time if > the given path to be compiled to *.lua.c is absolute, the output > file is generated in source directory instead of the binary one. This > patch fixes the latter case providing the valid behaviour for out of Typo: s/case providing/case, providing/ > source build type. > > Needed for #4862 > > Signed-off-by: Igor Munkin > --- > cmake/utils.cmake | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/cmake/utils.cmake b/cmake/utils.cmake > index eaec821b3..6d6960468 100644 > --- a/cmake/utils.cmake > +++ b/cmake/utils.cmake > @@ -40,9 +40,11 @@ endmacro(set_source_files_compile_flags) > -- > 2.25.0 > -- Best regards, Sergey Kaplun