From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 58D157030C; Tue, 9 Feb 2021 18:10:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 58D157030C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612883442; bh=ebvMLKI0g85e+yGeVckSpFBHQ7d3STLdsb2m+9ple58=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NwHPUk4qpqpU/EyJuA/HSpF0z3x3OhEj/j8J+QP5Y9CyNDRwA1DWtGilrtMC09KEU L8gRxWK4BdHiKvZ7jMzw0Ox49NVfbioM3zjotB6zvb0AWAdS//5c6Jo6buG+tslExI iZz+stC6G9rUkKBexdMVV/yQRovcJI3qdA5TQ76U= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7A5067030C for ; Tue, 9 Feb 2021 18:10:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7A5067030C Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1l9Uew-0001tj-LR; Tue, 09 Feb 2021 18:10:35 +0300 Date: Tue, 9 Feb 2021 18:10:33 +0300 To: Timur Safin Message-ID: <20210209151033.GJ5448@tarantool.org> References: <6a03d693204cacc5791c75e1003efc150abb2979.1612291495.git.imun@tarantool.org> <01d401d6fe2b$dd80c160$98824420$@tarantool.org> <20210208162930.GF5448@tarantool.org> <044301d6febb$ef1af8b0$cd50ea10$@tarantool.org> <20210209084319.GG5448@tarantool.org> <05ba01d6feeb$c962bfb0$5c283f10$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <05ba01d6feeb$c962bfb0$5c283f10$@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9C55152E5B36F7009490E3DBC75EBFD4CE182A05F538085040EFB589624B65DC03BC8B9E0E68CB26D2B773CDBF72AED14906E2737D9A1D3F1F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F8E53417176C7207EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF19945FAF91394A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC649E0843118E7619D5B2BEC0A697A24DFF0106606409DD06389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FC696E4123C2B4120575ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4930A3850AC1BE2E73528A6D463EDFD0DBBC4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A568EAAADC53CEFBABB5D0B97BBC59B0A3FD43183685B269F0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D8C933888226C84138B9BA827BB5CB8D92388C461FD231F0BD0B7F8B8CD0762C7A6BA4D05E7803301D7E09C32AA3244C57168E47E096FA5541CE36A15B77948FA95CA90A1D8AC565927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojg67HQLCbniJLnml1KlIe7A== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822F3295E8E19648E7AF353FF8A9AEB5F63A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/5] test: run LuaJIT tests via CMake X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Timur, On 09.02.21, Timur Safin wrote: > LGTM. Thanks, added your tag: | Reviewed-by: Timur Safin > Modulo my usual note about 2nd comment about cmake. But you may already has it > fixed in your branch till this moment... > > > : From: Igor Munkin > : Subject: Re: [PATCH luajit 3/5] test: run LuaJIT tests via CMake > : > : > : > : > : Unfortunately... CMake is a crap and I can't fix it. Well, honestly I > : > : don't want to fix it. But you're right: I can fix all these comments > : > : (athough I don't really want to). I have no idea how to express this in > : > : a more neutral way, so I propose the following: > : > : 1. s/CMake is a crap/there is no convenient way to make it in CMake/g. > : > : 2. Leave everything else unchanged. > : > > : > Hmm, ok. > : > : Fixed, squashed, force-pushed to the branch. Diff is below: > > Nice! Thank you! But there is 2nd one... > > : > : > > : > : > : > : This is not only emotions. Such comments prevent one from unintentional > : > : refactoring of such fragile places with no failures and also from > : > : bothering the oldies with the questions kinda "dude, why is this done so > : > : badly". In other words, primarily I have left this for the history. > : > : > : > : If you're OK, then I'll fix the way described above. > : > : > : > : > > : > : > : + # Add the directory where the lib is built to the LUA_CPATH > : > : > : + # environment variable, so interpreter can find and load it. > : > : > : + # XXX: Here we see the other side of the coin. If one joins two > : > : > : + # strings with semicolon, the value automatically becomes the > : > : > : + # list. I have no idea what is wrong with this tool, > > About this one ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Re-built comments with -UFLAME -UTOXIC, here are the changes: ================================================================================ diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt index 5345e12..a7af807 100644 --- a/test/tarantool-tests/CMakeLists.txt +++ b/test/tarantool-tests/CMakeLists.txt @@ -46,10 +46,10 @@ macro(BuildTestLib lib sources) # Add the directory where the lib is built to the LUA_CPATH # environment variable, so interpreter can find and load it. # XXX: Here we see the other side of the coin. If one joins two - # strings with semicolon, the value automatically becomes the - # list. I have no idea what is wrong with this tool, but I found - # a single working solution to make LUA_CPATH be a string via - # "escaping" the semicolon right in string interpolation. + # strings with semicolon, the value automatically becomes a + # list. I found a single working solution to make LUA_CPATH be + # a string via "escaping" the semicolon right in string + # interpolation. set(LUA_CPATH "${CMAKE_CURRENT_BINARY_DIR}/?${CMAKE_SHARED_LIBRARY_SUFFIX}\;${LUA_CPATH}" PARENT_SCOPE) # Also add this directory to LD_LIBRARY_PATH environment # variable, so FFI machinery can find and load it. ================================================================================ Squashed, force-pushed to the branch. > > : > : > : + but I found > : > : > : + # a single working solution to make LUA_CPATH be a string via > : > : > : + # "escaping" the semicolon right in string interpolation. > : > : > : + set(LUA_CPATH > : > : > : > : > : > > Regards, > Timur > -- Best regards, IM