From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 37FBF68713; Mon, 1 Feb 2021 13:01:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 37FBF68713 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1612173704; bh=Ac6kaJPfKK8PRrz2W/3NCbiv79qaAw/Ev/BhDZZEAUs=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lF93NDJLvwRSuXRvX5oIpJ0+A3fJW/9p3jy3wT3NfJC07DWOm3hD/wnjdCb8mUatH u/Chzg+eUI6wfmzUgg+/sWD+DAeDic0tIuiTMEXDbq9KdkQ0iswMT0gwjjW6gLb+88 ue2m7j4FMrcal3WxXceZxxJrfaJGTkvRQMLezyAI= Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 46577645EA for ; Mon, 1 Feb 2021 13:01:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 46577645EA Received: by mail-lj1-f172.google.com with SMTP id y14so6182157ljn.8 for ; Mon, 01 Feb 2021 02:01:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Z7sTQN/154Tw7UXUGXSJkWi6OAxUEfuueOatSqddsJE=; b=UkDYbtfxBCR6+UK5HM93k/ytgm3Ihm/H7c4jUkz1VuSyGyizz4/zuuCLMMf1jDl1Mj xE/5PRM0SEX/boJPsCP4p0DSV4X2vfhNs4mTRyjFEJZLhZLphRtAtV6GMFpt+bLxd5gk CV6Yi0Szq3lyudHqXDMhVw+u3fW4Eq8RD7DGVm/9cD0xWbNCatys8v1hDIJ8RlXir0Av gQTkDBaAsZ9vh2dlKHhTooDjjxGbsL/PRKjiPcL1XUBYxWiWFtPEtdwm3Z6azUxtdBHN M1FkXKpCjj/OQawnogCZiJ38A8rdDxfi/Xrc1soxivpNeMpmnU/PD48on0/hkCm4DtAj Tofw== X-Gm-Message-State: AOAM5330xO03RhQSekQUS8P6oF9xnB/7Kzq0CsnhF1E2T9NI3hZztx9m epmc2ijVKSMhaq3g0OFtibqLzElCeLYi6Q== X-Google-Smtp-Source: ABdhPJxo8R1PObhx1n+6HpBuZUV143NVWgDKts17cYBc/QTajbs5ba2a52XWBOb1gklF9/ZG4qq3Bw== X-Received: by 2002:a05:651c:1122:: with SMTP id e2mr10326671ljo.91.1612173667078; Mon, 01 Feb 2021 02:01:07 -0800 (PST) Received: from grain.localdomain ([5.18.103.226]) by smtp.gmail.com with ESMTPSA id t6sm3828652ljd.112.2021.02.01.02.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Feb 2021 02:01:05 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 0A79C56017C; Mon, 1 Feb 2021 13:00:40 +0300 (MSK) To: tml Date: Mon, 1 Feb 2021 13:00:36 +0300 Message-Id: <20210201100037.212301-3-gorcunov@gmail.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210201100037.212301-1-gorcunov@gmail.com> References: <20210201100037.212301-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v2 2/3] box/info: report replication.X.downstream.lag value X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is basically a reflection of replication.X.upstream.lag value. The upstream lag can be considered as transaction RTT in direction from master to replica, in turn downstream lag is the reverse and represents RTT from replica to master. An example of output is (on replica node) | 2: | id: 2 | uuid: 8bb22366-cd21-492e-98df-693884be11bd | lsn: 0 | downstream: | status: follow | idle: 0.55381065199617 | vclock: {1: 119} | lag: 0.00019168853759766 In case if there some old replicas which are not sending timestamp in vclock encoding we simply don't show lag field for backward compatibility sake. Closes #5447 @TarantoolBot document Title: Document box.info.replication[n].downstream.lag replication[n].downstream.lag is time difference between local time of the replica `n` sending current vector clock state and the time this message was received by a master node. Signed-off-by: Cyrill Gorcunov --- src/box/lua/info.c | 8 ++++++++ src/box/relay.cc | 16 ++++++++++++++++ src/box/relay.h | 8 ++++++++ 3 files changed, 32 insertions(+) diff --git a/src/box/lua/info.c b/src/box/lua/info.c index c4c9fa0a0..1e533fe8d 100644 --- a/src/box/lua/info.c +++ b/src/box/lua/info.c @@ -133,16 +133,24 @@ lbox_pushrelay(lua_State *L, struct relay *relay) switch(relay_get_state(relay)) { case RELAY_FOLLOW: + { + double lag = relay_lag(relay); lua_pushstring(L, "follow"); lua_settable(L, -3); lua_pushstring(L, "vclock"); lbox_pushvclock(L, relay_vclock(relay)); lua_settable(L, -3); + if (lag != 0) { + lua_pushstring(L, "lag"); + lua_pushnumber(L, relay_lag(relay)); + lua_settable(L, -3); + } lua_pushstring(L, "idle"); lua_pushnumber(L, ev_monotonic_now(loop()) - relay_last_row_time(relay)); lua_settable(L, -3); break; + } case RELAY_STOPPED: { lua_pushstring(L, "stopped"); diff --git a/src/box/relay.cc b/src/box/relay.cc index df04f8198..f23e43b30 100644 --- a/src/box/relay.cc +++ b/src/box/relay.cc @@ -138,6 +138,8 @@ struct relay { struct stailq pending_gc; /** Time when last row was sent to peer. */ double last_row_time; + /** Number of seconds this master is prior the remote replica. */ + double lag; /** Relay sync state. */ enum relay_state state; @@ -179,6 +181,12 @@ relay_last_row_time(const struct relay *relay) return relay->last_row_time; } +double +relay_lag(const struct relay *relay) +{ + return relay->lag; +} + static void relay_send(struct relay *relay, struct xrow_header *packet); static void @@ -219,6 +227,7 @@ relay_start(struct relay *relay, int fd, uint64_t sync, relay->sync = sync; relay->state = RELAY_FOLLOW; relay->last_row_time = ev_monotonic_now(loop()); + relay->lag = 0; } void @@ -558,6 +567,13 @@ relay_reader_f(va_list ap) /* vclock is followed while decoding, zeroing it. */ vclock_create(&relay->recv_vclock); xrow_decode_vclock_xc(&xrow, &relay->recv_vclock); + /* + * Old versions may send not a timestamp but + * zeroified memory field. We can use +0 as + * a sign that there is nothing encoded. + */ + if (xrow.tm != 0) + relay->lag = ev_now(loop()) - xrow.tm; fiber_cond_signal(&relay->reader_cond); } } catch (Exception *e) { diff --git a/src/box/relay.h b/src/box/relay.h index b32e2ea2a..ec9d16925 100644 --- a/src/box/relay.h +++ b/src/box/relay.h @@ -93,6 +93,14 @@ relay_vclock(const struct relay *relay); double relay_last_row_time(const struct relay *relay); +/** + * Returns relay's lag + * @param relay relay + * @returns relay's lag + */ +double +relay_lag(const struct relay *relay); + /** * Send a Raft update request to the relay channel. It is not * guaranteed that it will be delivered. The connection may break. -- 2.29.2