From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 61F5B70310; Wed, 27 Jan 2021 17:38:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 61F5B70310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611758310; bh=Npt3eiYzPF1WtsxjsqvSp4yZDNe3qiQZ0nccyzivq48=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=N3x3sg7yc481ecnkkf8F6G2LFzJ88It8lgjoj6npaJ0nni1ifbQKtgSNBD2Uc985m Y+vQfMPd3z1uX63zXa018VSC56SKuHFuaTKDTn6Rf2Cmoip/Mz/e0v+y0thKNwY+b9 5BQEixax5ffVHtpOku2pit5dxWd0f6yT8Yf8TGLg= Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A17CB70310 for ; Wed, 27 Jan 2021 17:38:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A17CB70310 Received: by mail-lf1-f53.google.com with SMTP id h7so2961728lfc.6 for ; Wed, 27 Jan 2021 06:38:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3HlnXQZpPi2oAzQmhGxRK3yAMvFvS8odgB/wdjuuO0k=; b=So5Ki0i88K1i1c9W53xA+FhMI4wLTsR4a0CKwt6SV9fwuat5+8pykZIaZj3QOEMJYf iVZiY14kFhyKOR+0g/t73TaUFuibS+BDR+xi0tJGF+FEg112uxG4rr5FuXRAHgzAAISg eCLKPNE/lPw37ZxcFad1LvOrkaPVMyq8OP10QROkCuWVGDBNq+JBDNQxz4BOlny78Ifn 5ANdqdAjEdaDzd/rqmq+ibRTvCrZNH2eYNdkQ/6qdtUbfQo1mwpV+VN75njc+Yr9UJsj tRjZOl3DiIcwZPFEnA20ksmgyLyYWnPC0KgIuxShBQzXJgPt723itQ0DHjVDEZQZeebS YY/g== X-Gm-Message-State: AOAM530zRpuoFaDXJyoe4O67wylpiXEHFeAqZCv8UWdJw564TR+99gwb QCHgc4oPZynYPxP5Il68/kiymnZMDGw= X-Google-Smtp-Source: ABdhPJy4+7VYDYpzzZLZfcPEcBD/Gv+Q6DHFxrqCi/lquUhMDonek0q2SdVTGV/K/D2WkA9t3P6zSw== X-Received: by 2002:ac2:515c:: with SMTP id q28mr5495511lfd.390.1611758308393; Wed, 27 Jan 2021 06:38:28 -0800 (PST) Received: from grain.localdomain ([5.18.91.94]) by smtp.gmail.com with ESMTPSA id z9sm527494lfc.125.2021.01.27.06.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 06:38:27 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 555E856009B; Wed, 27 Jan 2021 17:38:26 +0300 (MSK) Date: Wed, 27 Jan 2021 17:38:26 +0300 To: Serge Petrenko Cc: tml , Vladislav Shpilevoy Message-ID: <20210127143826.GL2174@grain> References: <20210121171753.186891-1-gorcunov@gmail.com> <20210121171753.186891-3-gorcunov@gmail.com> <14c1c58c-0645-0262-e70d-3bf92aa88a49@tarantool.org> <20210127121259.GK2174@grain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) Subject: Re: [Tarantool-patches] [PATCH 2/3] box/info: report replication.X.downstream.lag value X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Wed, Jan 27, 2021 at 05:04:27PM +0300, Serge Petrenko wrote: > > diff --git a/src/box/relay.cc b/src/box/relay.cc > > index 9265a26b3..a486db23a 100644 > > --- a/src/box/relay.cc > > +++ b/src/box/relay.cc > > @@ -571,7 +571,7 @@ relay_reader_f(va_list ap) > > /* > > * Old versions may send not a timestamp but > > * zeroified memory field. We can use +0 as > > - * as sign that there is nothing encoded. > > + * as a sign that there is nothing encoded. > > Now there's double "as". Look at the previous line. =) Heh :) Thanks! Pushed an update. --- [cyrill@grain tarantool.git] git diff diff --git a/src/box/relay.cc b/src/box/relay.cc index a486db23a..859069a7b 100644 --- a/src/box/relay.cc +++ b/src/box/relay.cc @@ -571,7 +571,7 @@ relay_reader_f(va_list ap) /* * Old versions may send not a timestamp but * zeroified memory field. We can use +0 as - * as a sign that there is nothing encoded. + * a sign that there is nothing encoded. */ if (xrow.tm != 0) relay->lag = ev_now(loop()) - xrow.tm;