From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 637807030E; Mon, 25 Jan 2021 13:29:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 637807030E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1611570584; bh=g6YjHAjvqwnbbh0U7KD4VNErDOcD8g/40AHJ1K3ecDU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=BRaptFcha9FdFTMp4L5liQI+EVo2RlrVW4Mu2lNYeby3ahcheqQbixWY8gY0x+WeR PFNlUrl8lYpO2VgSgoVBvJwK/sEG1Ko2MfqEGUn7r2o3/Gk0Mpgc4lPJPzeu+ig6p2 O5Fw4QeBQV5+yaMERQQIDriAIPrTPvIeCXMX2BLk= Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E507C7030E for ; Mon, 25 Jan 2021 13:29:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E507C7030E Received: by mail-lf1-f46.google.com with SMTP id f1so7106784lfu.3 for ; Mon, 25 Jan 2021 02:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6b+vNLa2XLHOSleqwTWOe53r2R0ZRaNDCLEDDg8lFdk=; b=nf/aVeZCke5NloByjg+EbTSlFw8Ig7mcVrr6uj5Y+bBuB61COh+UMb1Me/NQAmRxIy 2aZz+v3N4z2PL7RyDgp/4ues0r6NwsSarsa8UlqrflyR/Mp97r4z50wmR9o/Cm5ZOw2w BStXFSXvkYtWSprIZlgLSv0Dvka6saMIVTK1BALKuYIfte/cqHhBlziQGPDkN58srdyj 8xqvteuSH266Hyg5EvX1UV9oYQECay4kYDOPG2ZwpnCIn7VR3RDSVgEdwxnXA4ckNNNP WyRXlzG9AmXENf0o5NOpp0Pymm9Lnwm9SAlCEqg8UGJnjWFtHpbjFt6X7jaZKYFPRcdz DSXA== X-Gm-Message-State: AOAM533x7Pzok8z8GR7GB6B9EPd54hEz2uo4svcahbMBh+hnJg16ttfl rgPLAckZaAvPMl1pT3HBOC8dXGtDnAo= X-Google-Smtp-Source: ABdhPJyn6yVn2rg2YhI0A4G9CWFQB8owEH4PKTlUi7i4ua5jCx+5RDL9x/BVu7/aYeNi4e8T3Y2laQ== X-Received: by 2002:a19:155:: with SMTP id 82mr1071025lfb.468.1611570581613; Mon, 25 Jan 2021 02:29:41 -0800 (PST) Received: from grain.localdomain ([5.18.91.94]) by smtp.gmail.com with ESMTPSA id o14sm1976541ljp.48.2021.01.25.02.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 02:29:40 -0800 (PST) Received: by grain.localdomain (Postfix, from userid 1000) id 92EA7560113; Mon, 25 Jan 2021 13:29:39 +0300 (MSK) Date: Mon, 25 Jan 2021 13:29:39 +0300 To: Vladislav Shpilevoy Cc: tml Message-ID: <20210125102939.GF2174@grain> References: <20210118203556.281700-1-gorcunov@gmail.com> <20210118203556.281700-6-gorcunov@gmail.com> <5433464e-767f-bb63-0723-ef0752490a5e@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5433464e-767f-bb63-0723-ef0752490a5e@tarantool.org> User-Agent: Mutt/1.14.6 (2020-07-11) Subject: Re: [Tarantool-patches] [PATCH v12 5/8] module_cache: rename calls to ref in module structure X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Cyrill Gorcunov via Tarantool-patches Reply-To: Cyrill Gorcunov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On Sun, Jan 24, 2021 at 05:27:35PM +0100, Vladislav Shpilevoy wrote: > Thanks for the patch! > > Why isn't it in the third commit ("improve naming")? Because I wanna separate function descriptor changes from module refs. They are serving different purposes and moreover the refs patch changes the element type. > > - module->calls = 0; > > + module->ref = 0; > > I propose to be consistent with the other code and > call it 'refs' instead of 'ref' (see struct error, struct tuple, > struct tuple_format). Sure