Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Yukhin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: sergeyb@tarantool.org
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/vinyl
Date: Mon, 18 Jan 2021 13:41:31 +0000	[thread overview]
Message-ID: <20210118134131.rr7xhp7gn26lh44d@tarantool.org> (raw)
In-Reply-To: <8fc4ccf108670e084a735b2d2a4ea74d5c0c653d.1610614496.git.sergeyb@tarantool.org>

Hello,

On 14 янв 11:58, Sergey Bronnikov via Tarantool-patches wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Closes #5466
> 
> Reviewed-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Reviewed-by: Igor Munkin <imun@tarantool.org>
> 
> Co-authored-by: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
> Co-authored-by: Igor Munkin <imun@tarantool.org>
> ---
> Changelog v7:
> 
> - reverted changes with redefinitions
> - rebased to a master branch
> 
> Changelog v6:
> 
> - splitted patch in test/ for patches per sub-directory
> - adjusted supressions in .luacheckrc
> - fixed formatting issues in .luacheckrc
> - fixed warnings in test/vinyl/vinyl.lua and test/vinyl/large.lua
> 
> Gitlab CI: https://gitlab.com/tarantool/tarantool/-/pipelines/241521801
> Issue: https://github.com/tarantool/tarantool/issues/5466
> Branch: ligurio/gh-5466-luacheck-warnings-test-vinyl

I've checked your patch into 2.6, 2.7 and master.

--
Regards, Kirill Yukhin

      parent reply	other threads:[~2021-01-18 13:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14  8:58 Sergey Bronnikov via Tarantool-patches
2021-01-15 22:16 ` Vladislav Shpilevoy via Tarantool-patches
2021-01-18 13:41 ` Kirill Yukhin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210118134131.rr7xhp7gn26lh44d@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v7] test: fix luacheck warnings in test/vinyl' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox