From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7F45170310; Fri, 15 Jan 2021 23:32:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7F45170310 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610742758; bh=fauPpL0JGIjzYHklNzK1sHvlqFXdpKUhNDzowYyvV0k=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LZrBfBzI9PfFU+qMancXPBpwhSMHBKxX4M8t2KoesLzUIUeoh1tTMwJE9Z8FQwuqu L2MzddjlFNgo5K/nO9lcM132FzoS3SOHke1y5yGP0v/t4QETIN2fwNvFUBU0Zvk0h/ VXc0QLQl5JTV6P0+0aSyzBOfuqoPSc3QbqPFmwDg= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B5BC370310 for ; Fri, 15 Jan 2021 23:32:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B5BC370310 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1l0Vlr-0002lr-AJ; Fri, 15 Jan 2021 23:32:35 +0300 Date: Fri, 15 Jan 2021 23:32:33 +0300 To: Sergey Bronnikov Message-ID: <20210115203233.GB5460@tarantool.org> References: <82365527bf3aefe026e0c0e4d93f3acbb882391c.1610709207.git.sergeyb@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.10.1 (2018-07-13) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CD3BE40D5FE7B3134676ED03235248932300894C459B0CD1B942AED475C964B8588301DF9C7BABD8AB4FE048750704228897FFBCB1194FBF86 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637188F5654332B449D8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC4F88499FD0C15DFBBFE4D78027E4434AB6D6CE0E88A85485389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF3735872C767BF85DA29E625A9149C048EE0A3850AC1BE2E735F67BA0E7924E9B8D4AD6D5ED66289B524E70A05D1297E1BB35872C767BF85DA227C277FBC8AE2E8BECD345639C7F4A9E75ECD9A6C639B01B4E70A05D1297E1BBC6867C52282FAC85D9B7C4F32B44FF57285124B2A10EEC6C00306258E7E6ABB4E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5826894A604C4586FE23497B947F14939561742D2D264EBA6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C1E32F4AD4B2486BDD982D17C6D4DAA0687D8F648F8EA5D463AB45D5C7FA8B15640CC74C146697571D7E09C32AA3244CF88C50BFD2D89B972E7E2070BCEFF1D0B4DF56057A86259F83B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ4tq2Sme+hGlA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638227B5D6BFD6B443D8674466D505E08F7A3A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] luacheck: fix warnings in test/box X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Even I'm a bit late (Kirill is the fastest hand in the wild west^W^W Tarantool), I have a single nit regarding Serge question. On 15.01.21, Sergey Bronnikov via Tarantool-patches wrote: > Thanks for review! > > On 15.01.2021 15:39, Serge Petrenko wrote: > > > >> diff --git a/test/box/gh-5304-insert_during_recovery.lua > >> b/test/box/gh-5304-insert_during_recovery.lua > >> index ac6eef342..c8b6c5cfb 100644 > >> --- a/test/box/gh-5304-insert_during_recovery.lua > >> +++ b/test/box/gh-5304-insert_during_recovery.lua > >> @@ -1,24 +1,24 @@ > >>   #!/usr/bin/env tarantool > >>   -function none(old_space, new_space) > >> +local function none(old_space, new_space) -- luacheck: ignore > > > > What's "luacheck: ignore" comment for? Haven't you fixed the warning > > already by introducing `local` ? > > > There are two warnings here. First one about global scope, that was > fixed with "local" and second one > > about unused parameters, that was suppressed by "luacheck: ignore". AFAICS there is a specific ignore reason for inline suppressions such as "no unused args" that is used in other Lua sources repo-wide (just grep for it). You can also see other available inline reasons here[1]. > > >>   end > > [1]: https://luacheck.readthedocs.io/en/stable/inline.html -- Best regards, IM