From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <skaplun@tarantool.org>
Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DB2144765E0
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 30 Dec 2020 11:53:05 +0300 (MSK)
Date: Wed, 30 Dec 2020 11:52:18 +0300
From: Sergey Kaplun <skaplun@tarantool.org>
Message-ID: <20201230085218.GO14702@root>
References: <cover.1609278043.git.skaplun@tarantool.org>
 <a44cf48f548c623235218b4bf51bf268422b9191.1609278043.git.skaplun@tarantool.org>
 <20201230084946.GV5396@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201230084946.GV5396@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] misc: fix build with
	disabled memory profiler
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi, Igor!

Thanks for the review!

On 30.12.20, Igor Munkin wrote:
> Sergey,
> 
> Thanks for the patch! LGTM with a single nit below.
> 
> On 30.12.20, Sergey Kaplun wrote:
> > This patch fixes the regression introduced in scope of
> > b4e6bf0d82100049d29af1aa3196e781270f39d1 ('misc: add Lua API for memory
> > profiler'). Build is failed with disabled memory profiler because
> 
> Typo: s/is failed/fails/.

Fixed. Branch is force-pushed.

> 
> > related error messages are not defined.
> > 
> > This patch fixes build by making LJ_ERR_PROF_MISUSE visible and avoiding
> > usage of other profiler-related errors when the profiler is disabled.
> > 
> > Follows up tarantool/tarantool#5442
> > ---
> >  src/lib_misc.c  | 4 ++++
> >  src/lj_errmsg.h | 2 +-
> >  2 files changed, 5 insertions(+), 1 deletion(-)
> > 
> 
> <snipped>
> 
> > -- 
> > 2.28.0
> > 
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun