From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1CAA44765E0
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 30 Dec 2020 11:24:06 +0300 (MSK)
Date: Wed, 30 Dec 2020 11:24:03 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20201230082403.GA9301@hpalx>
References: <cover.1609278043.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1609278043.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH luajit 0/3] LuaJIT memory profiler
 bug fixes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Sergey, thanks for the patchset, as I see no new degradation found in
gitlab-ci testing commit criteria pipeline [1], patchset LGTM.

[1] - https://gitlab.com/tarantool/tarantool/-/pipelines/235622340

On Wed, Dec 30, 2020 at 01:22:55AM +0300, Sergey Kaplun via Tarantool-patches wrote:
> This patchset accumulate different fixes for memory profiler bugs
> introduced in scope of [1].
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-misc-memprof-fixes
> Branch CI: https://github.com/tarantool/tarantool/tree/skaplun/gh-noticket-misc-memprof-fixes
> 
> CI is red [2], [3] but it isn't related to the patch, AFAICS. It has failed
> before my commit (see [4], [5]).
> CI :https://gitlab.com/tarantool/tarantool/-/pipelines/235622340
> 
> [1]: https://github.com/tarantool/tarantool/issues/5442
> [2]: https://gitlab.com/tarantool/tarantool/-/jobs/936802176
> [3]: https://gitlab.com/tarantool/tarantool/-/jobs/936802176
> [4]: https://gitlab.com/tarantool/tarantool/-/jobs/936547205#L4118
> [5]: https://gitlab.com/tarantool/tarantool/-/pipelines/235383279
> 
> Sergey Kaplun (3):
>   misc: fix build with disabled memory profiler
>   core: fix resources leak in memory profiler
>   core: remove excess assertion inside memprof
> 
>  src/lib_misc.c   |  8 ++++----
>  src/lj_errmsg.h  |  2 +-
>  src/lj_memprof.c | 18 +++++++++++-------
>  3 files changed, 16 insertions(+), 12 deletions(-)
> 
> -- 
> 2.28.0
>