From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 56CFE4765E0 for ; Wed, 30 Dec 2020 11:18:09 +0300 (MSK) Date: Wed, 30 Dec 2020 08:18:04 +0000 From: Kirill Yukhin Message-ID: <20201230081804.cl2qjualbfennypt@tarantool.org> References: <6a0b559505240475037444d82c2345a66852b8ba.1609302497.git.alexander.turenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6a0b559505240475037444d82c2345a66852b8ba.1609302497.git.alexander.turenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] build: don't re-export libcurl.so/dylib symbols List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: Yaroslav Dynnikov , tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy Hello, On 30 Dec 07:53, Alexander Turenko wrote: > Export libcurl's symbols only when they are provided by tarantool > itself: when the library is linked statically into the tarantool's > executable. There is no much sense to export the symbols when we link > against the library dynamically. > > Regarding motivation of the change. Since 2.6.0-36-g29ec62891 ('Ensure > all curl symbols are exported') the curl_multi_poll() function is > exported from the tarantool executable. It leads to a failure in > Homebrew's build, because there we link (dynamically) with a system > libcurl. On Mac OS 10.15 it is libcurl 7.64.1, while the function > appears since libcurl 7.66.0. So a linker reports the undefined symbol: > `curl_multi_poll`. > > Now the symbols are not exported at dynamic linking with libcurl, so the > linker is happy. > > This commit relaxes bounds for dynamic linking, but an attempt to link > with libcurl older than 7.66.0 statically still leads to a linking > failure. The box-tap/gh-5223-curl-exports.test.lua test still fails when > tarantool is linked (dynamically) against an old libcurl. > > It looks as the good compromise. When libcurl functionality is provided > by tarantool itself, *all* functions listed in the test are present > (otherwise a linker will complain). But tarantool does not enforce a > newer libcurl version, when it just *uses* this functionality and don't > provide it for modules and stored procedured. It is not tarantool's > responsibility in the case. > > We possibly should skip the box-tap/gh-5223-curl-exports.test.lua test > when tarantool is built against libcurl dynamically or revisit the > described approach. I'll leave it as possible follow up activity. > > Fixes #5542 LGTM. I've checked your patch into 2.6 and master. -- Regards, Kirill Yukhin