From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 573844765E0
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Dec 2020 23:16:21 +0300 (MSK)
Date: Tue, 29 Dec 2020 23:16:35 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201229201635.6jremx73yrtgnqdj@tkn_work_nb>
References: <cover.1609259010.git.artemreyt@tarantool.org>
 <54be7a8eac0b6f9291e03b7f9ef26bbcc367e7b0.1609259010.git.artemreyt@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <54be7a8eac0b6f9291e03b7f9ef26bbcc367e7b0.1609259010.git.artemreyt@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/3] test: new version for -e
	assert(false) test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Artem Starshov <artemreyt@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Tue, Dec 29, 2020 at 07:25:35PM +0300, Artem Starshov wrote:
> Functions with timeout transferred to module
> test/app-tap/lua/process_timeout.lua for futher
> using in other tests.

Typo: futher -> further.

> 
> Before this version of test was already done,
> but by mistake older version was rebased on
> master.

BTW, I would mark all such commits as 'Follows up #4983'. It is a kind
of grouping and may help to navigate over the history in a future.

> -local fiber = require('fiber')
> -local clock = require('clock')
> -local ffi = require('ffi')
> -local fio = require('fio')
> -local errno = require('errno')
> +local common = require('process_timeout')

Why 'common', not 'process_timeout'?

> diff --git a/test/app-tap/lua/process_timeout.lua b/test/app-tap/lua/process_timeout.lua
> new file mode 100644
> index 000000000..141fb0e43
> --- /dev/null
> +++ b/test/app-tap/lua/process_timeout.lua

I would leave a comment that will describe a reason, why those functions
are necessary in presence of the 'popen' built-in module.