From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 96E604765E0
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 29 Dec 2020 19:33:51 +0300 (MSK)
Date: Tue, 29 Dec 2020 19:34:05 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20201229163405.a3ghkqm5izau5hle@tkn_work_nb>
References: <20201228181729.640270-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201228181729.640270-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] crash: extend report with instance
 data
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, tml <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Mon, Dec 28, 2020 at 09:17:29PM +0300, Cyrill Gorcunov via Tarantool-patches wrote:
> Product team would prefer to have more data to
> be included into a crash report.
> 
> So we add "instance" key with appropriate values
> (just like regular feedback entry has). For example
> 
> | {
> |   "crashdump": {
> |     "version": "1",
> |     "data": {
> |       "uname": {
> |         "sysname": "Linux",
> |         "release": "5.9.14-100.fc32.x86_64",
> |         "version": "#1 SMP Fri Dec 11 14:30:38 UTC 2020",
> |         "machine": "x86_64"
> |       },
> |       "instance": {
> |         "server_id": "336bfbfd-9e71-4728-91e3-ba84aec4d7ea",
> |         "cluster_id": "176f3669-488f-46a5-a744-1be0b8a31029",
> |         "uptime": "3"
> |       },
> |       "build": {
> |         "version": "2.7.0-183-g02970b402",
> |         "cmake_type": "Linux-x86_64-Debug"
> |       },
> |       "signal": {
> |         "signo": 11,
> |         "si_code": 0,
> |         "si_addr": "0x3e800095fb9",
> |         "backtrace": "#0  0x6317ab in crash_collect+bf...",
> |         "timestamp": "2020-12-28 21:09:29 MSK"
> |       }
> |     }
> |   }
> | }
> 
> Closes #5668
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
> issue https://github.com/tarantool/tarantool/issues/5668
> branch gorcunov/gh-5668-crash-extend

LGTM.

Pushed to master.

CCed Kirill.

WBR, Alexander Turenko.