From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 002E44765E0
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Dec 2020 11:17:09 +0300 (MSK)
Date: Mon, 28 Dec 2020 11:17:03 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201228081703.GU5396@tarantool.org>
References: <20201228070431.31068-1-skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201228070431.31068-1-skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] build: embed LuaJIT memory profiler
	tools
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

On 28.12.20, Sergey Kaplun wrote:
> This patch embeds a parser for binary data dumped via the memory
> profiler to Tarantool binary.
> 
> It is a set of the following Lua modules:
> * utils/bufread.lua: read binary data from a file.
> * utils/symtab.lua: symbol table decode functions
> * memprof/parse.lua: decode the memory profiler event stream
> * memprof/humanize.lua: display decoded data in human readable format
> * memprof.lua: Lua script and module to display data
> 
> It launch with the following command:
> $ tarantool -e 'require("memprof")(arg[1])' - filename.bin
> 
> Closed #5490
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/5490
> Branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5442-luajit-memory-profiler
> CI: https://gitlab.com/tarantool/tarantool/-/commits/skaplun/gh-5442-luajit-memory-profiler

I've checked your patch master.

> 

<snipped>

>  
> -- 
> 2.28.0
> 

-- 
Best regards,
IM