From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E04D54765E0
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Dec 2020 11:15:14 +0300 (MSK)
Date: Mon, 28 Dec 2020 11:15:08 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201228081508.GT5396@tarantool.org>
References: <cover.1608907726.git.skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1608907726.git.skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

On 25.12.20, Sergey Kaplun wrote:
> 
> This patch provides a Lua interface for memory profiler in LuaJIT
> and the corresponding parser of profiled data.
> 
> Global changes in v2:
>   - Moved symtab to memprof module.
>   - Added LUA_CORE and `module_name`_c defines
>   - Added LJ_FASTCALL in wbuf and leb128 modules.
>   - Added translation units to amalg build.
>   - Code style fixes and commit message fixes.
>   - Added (gh-5490) to ChangeLog.
> 
> Issues: https://github.com/tarantool/tarantool/issues/5442
>         https://github.com/tarantool/tarantool/issues/5490
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5442-luajit-memory-profiler
> 
> CI:     https://gitlab.com/tarantool/tarantool/-/pipelines/234430645
> 
> RFC: https://lists.tarantool.org/pipermail/tarantool-discussions/2020-December/000147.html
> 
> @ChangeLog:
>  - Introduce LuaJIT memory profiler (gh-5442).
>  - Introduce LuaJIT memory profiler parser (gh-5490).
> 
> Sergey Kaplun (7):
>   utils: introduce leb128 reader and writer
>   core: introduce write buffer module
>   vm: introduce VM states for Lua and fast functions
>   core: introduce new mem_L field
>   core: introduce memory profiler
>   misc: add Lua API for memory profiler
>   tools: introduce a memory profile parser

I've checked your patchset into tarantool/luajit bleeding branch and
bumped a new version in Tarantool master.

> 

<snipped>

> -- 
> 2.28.0
> 

-- 
Best regards,
IM