From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 150EF4765E0
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Dec 2020 08:33:12 +0300 (MSK)
Date: Mon, 28 Dec 2020 08:33:06 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201228053306.GQ5396@tarantool.org>
References: <cover.1608907726.git.skaplun@tarantool.org>
 <03ac70e3bfb9bf7061ad71c1bac50ed3f8e853fc.1608907726.git.skaplun@tarantool.org>
 <20201226225651.GI5396@tarantool.org> <20201227071656.GA9101@root>
 <20201228053027.GK14702@root>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201228053027.GK14702@root>
Subject: Re: [Tarantool-patches] [PATCH luajit v2 7/7] tools: introduce a
 memory profile parser
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Neato, LGTM.

On 28.12.20, Sergey Kaplun wrote:
> Adjusted <memprof.lua> to more painless integration with Tarantool.
> See the iterative patch below. Branch is force-pushed.
> 
> ===================================================================
> diff --git a/tools/memprof.lua b/tools/memprof.lua
> index 92d192e..a98e192 100644
> --- a/tools/memprof.lua
> +++ b/tools/memprof.lua
> @@ -90,7 +90,7 @@ local function parseargs(args)
>    return args[args.argn]
>  end
>  
> -local inputfile = parseargs{...}
> +local inputfile = parseargs(arg)
>  
>  local reader = bufread.new(inputfile)
>  local symbols = symtab.parse(reader)
> @@ -107,3 +107,5 @@ stdout:write("\n")
>  stdout:write("DEALLOCATIONS", "\n")
>  view.render(events.free, symbols)
>  stdout:write("\n")
> +
> +os.exit(0)
> ===================================================================
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM