From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A46444765E0
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 28 Dec 2020 08:14:38 +0300 (MSK)
Date: Mon, 28 Dec 2020 08:14:32 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20201228051432.GP5396@tarantool.org>
References: <cover.1608907726.git.skaplun@tarantool.org>
 <20201228040533.4057-1-skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201228040533.4057-1-skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH luajit v3 3/7] vm: introduce VM
 states for Lua and fast functions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sergey,

Thanks for the fixes! LGTM.

On 28.12.20, Sergey Kaplun wrote:
> This patch introduces LJ_VMST_LFUNC and LJ_VMST_FFUNC VM states
> separated from LJ_VMST_INERP. New VM states allow to determine the
> context of Lua VM execution for x86 and x64 arches. Also, LJ_VMST_C is
> renamed to LJ_VMST_CFUNC for naming consistence with new VM states.
> 
> Also, this patch adjusts stack layout for x86 and x64 arches to save VM
> state for its consistency while stack unwinding when error is raised.
> 
> To group all traces into the one vmstate, a special
> macro LJ_VMST_TRACE equal to LJ_VMST__MAX is introduced.
> 
> Part of tarantool/tarantool#5442
> ---
> 
> Changes in v3:
>  * Adjusted vmstate saving.
>  * Fix Win X64.
>  * Fix typos in frame layout.
>  * Codestyle fixes.
> 
>  src/lj_frame.h     |  16 ++---
>  src/lj_obj.h       |  11 +++-
>  src/lj_profile.c   |   5 +-
>  src/luajit-gdb.py  |  14 +++--
>  src/vm_arm.dasc    |   6 +-
>  src/vm_arm64.dasc  |   6 +-
>  src/vm_mips.dasc   |   6 +-
>  src/vm_mips64.dasc |   6 +-
>  src/vm_ppc.dasc    |   6 +-
>  src/vm_x64.dasc    |  93 +++++++++++++++++++++--------
>  src/vm_x86.dasc    | 146 ++++++++++++++++++++++++++++++++-------------
>  11 files changed, 218 insertions(+), 97 deletions(-)
> 

<snipped>

> -- 
> 2.28.0
> 

-- 
Best regards,
IM