From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <skaplun@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id EFAD04765E0
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 26 Dec 2020 22:42:59 +0300 (MSK)
Date: Sat, 26 Dec 2020 22:42:14 +0300
From: Sergey Kaplun <skaplun@tarantool.org>
Message-ID: <20201226194214.GZ9101@root>
References: <cover.1608907726.git.skaplun@tarantool.org>
 <47fe3e90153279081caedd4799a0e0dffdfac7be.1608907726.git.skaplun@tarantool.org>
 <E9D35921-9EC4-40DA-AA7E-0429226D650D@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <E9D35921-9EC4-40DA-AA7E-0429226D650D@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH luajit v2 4/7] core: introduce new
	mem_L field
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

Thanks for the review!

On 26.12.20, Sergey Ostanevich wrote:
> Hi!
> 
> Just some nits in the message, LGTM.
> 
> Sergos.
> 
> > On 25 Dec 2020, at 18:26, Sergey Kaplun <skaplun@tarantool.org> wrote:
> > 
> > To determine currently allocating coroutine (that may not be equal to
> > currently executed one) a new field called mem_L is added to
>                                remove^^^^^^^                  ^ the

Reworded commit message.

> > global_State structure. This field is set on each allocation event and
> > stores the coroutine address that is used for allocation.
> > 
> > Part of tarantool/tarantool#5442
> > ---

<snipped>

> > 2.28.0
> > 
> 

Reworded commit message to the following. Branch is force-pushed.

===================================================================
core: introduce new mem_L field

To determine currently allocating coroutine (that may not be equal to
currently executed one) a new field mem_L is added to the
global_State structure. This field is set on each allocation event and
stores the coroutine address that is used for allocation.

Part of tarantool/tarantool#5442
===================================================================

-- 
Best regards,
Sergey Kaplun