From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 550F24765E0 for ; Fri, 25 Dec 2020 13:04:43 +0300 (MSK) Date: Fri, 25 Dec 2020 10:04:41 +0000 From: Kirill Yukhin Message-ID: <20201225100441.vunidyl22kozt4fi@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 0/6] make clear_synchro_queue commit everything List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 23 Dec 14:59, Serge Petrenko via Tarantool-patches wrote: > Changes in v2: > - implement something similar to relay_lsn_watcher with the help of triggers. > - fix election_qsync_stress test hang. One issue with the test itself and one > issue with the txn_limbo. > - various minor fixes. > - change clear_synchro_queue behaviour: wait for quorum for > replication_synchro_timeout. If the quorum isn't reached, rollback nothing, > and warn the user. > > @ChangeLog > - Change `box.ctl.clear_synchro_queue` behaviour. Now it tries to commit > everything that is present on the node. In order to do so it waits for other > instances to replicate the data for `replication_synchro_quorum` seconds. > In case timeout passes and quorum wasn't reached, nothing is rolled back (gh-5435) I've checked your patchset into 2.6 and master. -- Regards, Kirill Yukhin