From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 744794765E0 for ; Fri, 25 Dec 2020 11:47:03 +0300 (MSK) Date: Fri, 25 Dec 2020 11:46:17 +0300 From: Sergey Kaplun Message-ID: <20201225084617.GQ9101@root> References: <7f5108768b70c9ffd2561f89c4974379085921e4.1608142899.git.skaplun@tarantool.org> <20201220224433.GQ5396@tarantool.org> <20201223223454.GF9101@root> <20201224091120.GY5396@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201224091120.GY5396@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH luajit v1 02/11] utils: introduce leb128 reader and writer List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org On 24.12.20, Igor Munkin wrote: > Sergey, > > On 24.12.20, Sergey Kaplun wrote: > > Igor, > > > > Thanks for the review! > > > > On 21.12.20, Igor Munkin wrote: > > > Sergey, > > > > > > Thanks for the patch! Please, consider the comments below. > > > > > > On 16.12.20, Sergey Kaplun wrote: > > > > > > > diff --git a/src/utils/leb128.c b/src/utils/leb128.c > > > > new file mode 100644 > > > > index 0000000..921e5bc > > > > --- /dev/null > > > > +++ b/src/utils/leb128.c > > > > @@ -0,0 +1,124 @@ > > > > +/* > > > > +** Working with LEB128/ULEB128 encoding. > > > > +** > > > > +** Major portions taken verbatim or adapted from the LuaVela. > > > > +** Copyright (C) 2015-2019 IPONWEB Ltd. > > > > +*/ > > > > + > > > > +#include > > > > +#include > > > > > > Why do you include this again instead of using leb128.h? > > > > It's enough. Definitions from is redundant here. > > Sorry, what definitions are *redundant* here? You're right. Sorry. Fixed. > > > > > > > > > > + > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun