From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1462D4765E0 for ; Fri, 25 Dec 2020 11:45:53 +0300 (MSK) Date: Fri, 25 Dec 2020 11:45:08 +0300 From: Sergey Kaplun Message-ID: <20201225084508.GP9101@root> References: <20201221103052.GU5396@tarantool.org> <20201224070011.GK9101@root> <20201224093628.GZ5396@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201224093628.GZ5396@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH luajit v1 04/11] profile: introduce symtab write module List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Igor, On 24.12.20, Igor Munkin wrote: > Sergey, > > On 24.12.20, Sergey Kaplun wrote: > > Igor, > > > > Thanks for the review! > > > > On 21.12.20, Igor Munkin wrote: > > > Sergey, > > > > > > Thanks for the patch! Please consider minor comments below. > > > > > > On 16.12.20, Sergey Kaplun wrote: > > > > > > > diff --git a/src/profile/ljp_symtab.c b/src/profile/ljp_symtab.c > > > > new file mode 100644 > > > > index 0000000..5a17c97 > > > > --- /dev/null > > > > +++ b/src/profile/ljp_symtab.c > > > > @@ -0,0 +1,55 @@ > > > > > > > > > > > > > +#define LJS_CURRENT_VERSION 2 > > > > > > Why is it already the second version? > > > > It's inherited from LuaVela. I didn't know is it right to drop version > > to zero. But AFAICS from your comment it is :) > > Why zero? I believe the most natural way to number versions starts with > the *first* version (zero versions are often considered as something not > ready to be released or unstable). Anyway, this value breaks nothing and > should be just incremented for the future symtab changes, so feel free > to use zero, if you want. Hmm, my bad. It's MVP, but stable MVP (as we suppose)(:. So lets use the first verison. > > > > > > > > > > + > > > > > > > -- > > Best regards, > > Sergey Kaplun > > -- > Best regards, > IM -- Best regards, Sergey Kaplun