From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com
 [209.85.167.47])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 262114765E0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Dec 2020 20:33:35 +0300 (MSK)
Received: by mail-lf1-f47.google.com with SMTP id m12so6022789lfo.7
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Dec 2020 09:33:35 -0800 (PST)
Date: Thu, 24 Dec 2020 20:33:31 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201224173331.GC298600@grain>
References: <20201223154155.234884-1-gorcunov@gmail.com>
 <20201223154155.234884-5-gorcunov@gmail.com>
 <30a781d7-4f4e-3543-f67e-2fb1f7cce172@tarantool.org>
 <20201223212253.GA298600@grain> <20201224131601.GB298600@grain>
 <8c0b2bda-5614-eac0-c0b9-36630c4bf315@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8c0b2bda-5614-eac0-c0b9-36630c4bf315@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v5 4/4] crash: report crash data to
 the feedback server
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Dec 24, 2020 at 06:15:02PM +0100, Vladislav Shpilevoy wrote:
> On 24.12.2020 14:16, Cyrill Gorcunov wrote:
> > On Thu, Dec 24, 2020 at 12:22:53AM +0300, Cyrill Gorcunov wrote:
> >> On Wed, Dec 23, 2020 at 07:47:44PM +0100, Vladislav Shpilevoy wrote:
> >>> Hi! Thanks for the patch!
> >>>
> >>> See 3 comments and fixes below, and top of the branch in a
> >>> separate commit.
> >>>
> >>
> >> Vlad, since we can use json_escape I dropped usage of base64
> >> encoder for backtrace. The final interdiff I pushed into
> >> gorcunov/gh-5261-crash-report-6 is the following
> > 
> > FWIW gorcunov/gh-5261-crash-report-6 passes all tests
> > https://gitlab.com/tarantool/tarantool/-/pipelines/234153923
> 
> The branch didn't work on my machine when I tried to crash Tarantool.
> Because uname.version even being json-escaped contained a substring
> which is not a valid Lua string. This was the broken string:
> 
> 	"Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2\/RELEASE_X86_64"
> 
> Lua didn't understand symbol sequence `\/`.
> 
> To workaround this I made the child process accept the dump data and
> the feedback host via command line arguments. Now seems to be working.
> 
> I pushed my fixes on top of the branch, and pasted them below.

Thanks a huge! Squashed into gorcunov/gh-5261-crash-report-7