From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A83C04765E0
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 24 Dec 2020 13:58:59 +0300 (MSK)
Date: Thu, 24 Dec 2020 10:58:58 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20201224105858.GB14559@tarantool.org>
References: <265e8f7a40dcedbfb67813643ef053cc76047e0c.1608750877.git.imeevma@gmail.com>
 <20201224104838.GA14559@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20201224104838.GA14559@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: do not reset region on
 select
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org, tarantool-patches@dev.tarantool.org

On 24 Dec 10:48, Nikita Pettik via Tarantool-patches wrote:
> On 23 Dec 22:15, imeevma@tarantool.org wrote:
> > Prior to this patch, region on fiber was reset during select(), get(),
> > count(), max(), or min(). This would result in an error if one of these
> > operations was used in a user-defined function in SQL. After this patch,
> > these functions truncate region instead of resetting it.
> > 
> > Closes #5427
> > ---
> > https://github.com/tarantool/tarantool/issues/5427
> > https://github.com/tarantool/tarantool/tree/imeevma/gh-5427-lua-func-changes-result
> > 
> > @ChangeLog
> >  - Fixed memory corruption when SQL called Lua functions with box calls inside (gh-5427).
> 
> Nice fix, LGTM.
>

Pushed to master, 2.6 and 2.5; updated chagelogs correspondingly; branch
is dropped. Thx.