From: Nikita Pettik <korablev@tarantool.org>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: do not reset region on select
Date: Thu, 24 Dec 2020 10:48:38 +0000 [thread overview]
Message-ID: <20201224104838.GA14559@tarantool.org> (raw)
In-Reply-To: <265e8f7a40dcedbfb67813643ef053cc76047e0c.1608750877.git.imeevma@gmail.com>
On 23 Dec 22:15, imeevma@tarantool.org wrote:
> Prior to this patch, region on fiber was reset during select(), get(),
> count(), max(), or min(). This would result in an error if one of these
> operations was used in a user-defined function in SQL. After this patch,
> these functions truncate region instead of resetting it.
>
> Closes #5427
> ---
> https://github.com/tarantool/tarantool/issues/5427
> https://github.com/tarantool/tarantool/tree/imeevma/gh-5427-lua-func-changes-result
>
> @ChangeLog
> - Fixed memory corruption when SQL called Lua functions with box calls inside (gh-5427).
Nice fix, LGTM.
next prev parent reply other threads:[~2020-12-24 10:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 19:15 imeevma
2020-12-24 10:48 ` Nikita Pettik [this message]
2020-12-24 10:58 ` Nikita Pettik
-- strict thread matches above, loose matches on Subject: below --
2020-11-02 9:49 imeevma
2020-11-04 22:14 ` Vladislav Shpilevoy
2020-12-16 5:34 ` Mergen Imeev
2020-12-17 22:04 ` Vladislav Shpilevoy
2020-12-22 19:30 ` Mergen Imeev
2020-12-23 14:58 ` Vladislav Shpilevoy
2020-12-23 19:20 ` Mergen Imeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201224104838.GA14559@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v1 1/1] sql: do not reset region on select' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox