From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B8A0C4765E0 for ; Thu, 24 Dec 2020 12:11:25 +0300 (MSK) Date: Thu, 24 Dec 2020 12:11:20 +0300 From: Igor Munkin Message-ID: <20201224091120.GY5396@tarantool.org> References: <7f5108768b70c9ffd2561f89c4974379085921e4.1608142899.git.skaplun@tarantool.org> <20201220224433.GQ5396@tarantool.org> <20201223223454.GF9101@root> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201223223454.GF9101@root> Subject: Re: [Tarantool-patches] [PATCH luajit v1 02/11] utils: introduce leb128 reader and writer List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Sergey, On 24.12.20, Sergey Kaplun wrote: > Igor, > > Thanks for the review! > > On 21.12.20, Igor Munkin wrote: > > Sergey, > > > > Thanks for the patch! Please, consider the comments below. > > > > On 16.12.20, Sergey Kaplun wrote: > > > diff --git a/src/utils/leb128.c b/src/utils/leb128.c > > > new file mode 100644 > > > index 0000000..921e5bc > > > --- /dev/null > > > +++ b/src/utils/leb128.c > > > @@ -0,0 +1,124 @@ > > > +/* > > > +** Working with LEB128/ULEB128 encoding. > > > +** > > > +** Major portions taken verbatim or adapted from the LuaVela. > > > +** Copyright (C) 2015-2019 IPONWEB Ltd. > > > +*/ > > > + > > > +#include > > > +#include > > > > Why do you include this again instead of using leb128.h? > > It's enough. Definitions from is redundant here. Sorry, what definitions are *redundant* here? > > > > > > + > > -- > Best regards, > Sergey Kaplun -- Best regards, IM